get rid of SITE_ID (for multiple site installation)

[gassan]

subj

[danirus]

Thanks @gassan for taking the time to do this.

I would prefer not to wrap django.contrib.sites.shortcuts.get_current_site. I haven't seen any Django project using this package without django.contrib.sites installed, however I think it's safe to have the fallback you added when there's no pk attribute.

Did you consider getattr(get_current_site(request), "pk", 1) instead of creating utils.get_site_id?

The CI issues are most probably because you go beyond column 79. I would appreciate if you could keep that constraint.
Thanks again.

[gassan]

Did you consider getattr(get_current_site(request), "pk", 1) instead of creating utils.get_site_id?

Good idea - I will use getattr and fix line lengths later this week

[gassan]

I need the shortcut utils.get_current_site_id - this function is called from 11 places.

[gassan]

use pip<19 for install from github.
pip install git+https://github.com/gassan/django-comments-xtd.git@nositeid

[danirus]

Just an observation here, if no request is passed to reverse here, there's no point on keeping the _reverse function. You can replace all the calls to _reverse with the original reverse.

[gassan]

Hmm, yes you are right here

[danirus]

Thanks @gassan,
and sorry for the long delay.