New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse-filters is really, really slow #13

Closed
bitemyapp opened this Issue Jul 9, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@bitemyapp

bitemyapp commented Jul 9, 2013

I don't know if this was the case before, but parse-filters is really slow.

The best way I can think to optimize this is to move as much of the template parsing into the pre-context-aware section and turn the filters into memoizable call-sites for injecting the data after the fact.

This would probably require writing a chunk of the parser into something that does as little as possible at the context-aware stage.

It also seems like a lot of time is being spent in the lazy-seq operations.

Do you know anything about this @danlarkin?

@danlarkin

This comment has been minimized.

Show comment
Hide comment
@danlarkin

danlarkin Jul 10, 2013

Owner

It doesn't surprise me that it's slow, as not much (any) time has been spent thinking about performance. If you want to explore ideas on how to speed it up that would be totally rad, thanks!

Owner

danlarkin commented Jul 10, 2013

It doesn't surprise me that it's slow, as not much (any) time has been spent thinking about performance. If you want to explore ideas on how to speed it up that would be totally rad, thanks!

@bitemyapp bitemyapp closed this Jun 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment