unable to set timeout option in `request` options object on parseUrl #46

Closed
rdbcci opened this Issue Feb 2, 2013 · 3 comments

Comments

Projects
None yet
2 participants

rdbcci commented Feb 2, 2013

feedparser README.md documentation seems to indicate all request options are available to be set. however, code indicates that only 'header' options are passed.

rdbcci commented Feb 2, 2013

suggesting code at 1231-1242 in main.js changes to something like:

var req = {};
req.headers = { 'Accept-Encoding': 'identity' };
if (typeof url === 'object') {
if ('headers' in url) {
utils.merge(req.headers, url.headers);
}
utils.merge(req, url, true);
}
else {
req.uri = url;
}

Owner

danmactough commented Feb 2, 2013

Yup. Thanks.

@danmactough danmactough added a commit that referenced this issue Feb 18, 2013

@danmactough danmactough Fix .parseUrl url parameter processing. Throw early if no valid url i…
…s given. Also pass all options to request. Add tests. Closes #44 and #46.
c90b65b
Owner

danmactough commented Feb 18, 2013

Closed by c90b65b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment