a null meta.title causes meta event to emit once for each article #69

Closed
rdbcci opened this Issue Jun 12, 2013 · 1 comment

Projects

None yet

2 participants

@rdbcci

at main.295 and .308 FeedParser makes a check to see if all meta data is parsed. However, check is made with !this.meta.title. if the meta.title is parsed to null this check is true and emits a meta event. this url currently has a null meta.title: 'http://www.zerohedge.com/fullrss2.xml'

@danmactough danmactough added a commit that referenced this issue Jun 13, 2013
@danmactough Only emit meta once.
title is a required channel element, so a feed without it is broken, but emitting more than once is still a no-no.
Closes #69
728201c
@danmactough danmactough added a commit that closed this issue Jun 13, 2013
@danmactough Only emit meta once.
title is a required channel element, so a feed without it is broken, but emitting more than once is still a no-no.
Closes #69

Conflicts:
	main.js
be9b097
@danmactough
Owner

@rdbcci Thanks for reporting this. FWIW, it is not valid for a feed to not have a title. But in any event, feedparser should only emit meta once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment