Remove reflection from the markup block in library code. #240

Closed
wants to merge 16 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

sam-truscott commented Feb 13, 2014

Make the reflection source-code based.

Previously the reflection was applied to markup languages but reflection is part of the Qt C++ spec and not markup so that reflection block should be removed from markup and made generic.

Sam Truscott and others added some commits Oct 23, 2013

Owner

danmar commented Feb 14, 2014

Can you cleanup this pull request. So it only contains 1 commit. You could rebase your branch or something.

Contributor

sam-truscott commented Feb 14, 2014

I've not done a rebase but I'll give it a go!

Contributor

sam-truscott commented Feb 14, 2014

In short, no, it's taking too long. If you insist I can just delete; patch and re-create the Pull request?

Contributor

scriptum commented Feb 14, 2014

Try something like:

git reset --soft <first commit> git commit "one big commit" git push --force

git push --force will remove all your commits for remote repo and forces it to match exactly your local repo. Of course I recommend to make backup of local repo:)

Owner

danmar commented Mar 3, 2014

I close this. Feel free to reopen or open a new pull request when you are ready.

danmar closed this Mar 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment