Skip to content

Fix #11393 FP danglingLifetime with pointer to pointer #7226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Jan 15, 2025
Merged

Fix #11393 FP danglingLifetime with pointer to pointer #7226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c14c52
Update testautovariables.cpp
chrchr-github Jan 15, 2025
0566298
Update checkautovariables.cpp
chrchr-github Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/checkautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ void CheckAutoVariables::checkVarLifetimeScope(const Token * start, const Token
if (var && !var->isLocal() && !var->isArgument() && !(val.tokvalue && val.tokvalue->variable() && val.tokvalue->variable()->isStatic()) &&
!isVariableChanged(nextTok,
tok->scope()->bodyEnd,
var->valueType() ? var->valueType()->pointer : 0,
Copy link
Contributor

@pfultz2 pfultz2 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I recall the pointer value is different than the indirect value.

Copy link
Collaborator Author

@chrchr-github chrchr-github Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then how do we get the correct value here?

Copy link
Contributor

@pfultz2 pfultz2 Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the pointer a bitset that sets each level indirection? Or is that just const?

Copy link
Collaborator Author

@chrchr-github chrchr-github Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

///< 0=>not pointer, 1=>*, 2=>**, 3=>***, etc
constness and volatileness are bitsets.

Copy link
Contributor

@pfultz2 pfultz2 Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was confused.

var->declarationId(),
var->isGlobal(),
*mSettings)) {
Expand Down
15 changes: 15 additions & 0 deletions test/testautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,21 @@ class TestAutoVariables : public TestFixture {
" int *ptr;\n"
"};");
ASSERT_EQUALS("", errout_str());

check("struct R {\n" // #11393
" void pop() { p = nullptr; };\n"
" int* p;\n"
"};\n"
"struct T {\n"
" void f();\n"
" R* r;\n"
"};\n"
"void T::f() {\n"
" int i = 0;\n"
" r->p = &i;\n"
" r->pop();\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void returnLocalVariable1() {
Expand Down
Loading