Skip to content

cmake/cxx11.cmake: dropped explicit setting of C++17 for Visual Studio with Qt6 #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 1 commit into from
Apr 14, 2025
Merged

cmake/cxx11.cmake: dropped explicit setting of C++17 for Visual Studio with Qt6 #7464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions cmake/cxx11.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
macro(use_cxx11)
# some GitHub Action Windows runners randomly fail with a complaint that Qt6 requires a C++17 compiler
if(MSVC AND USE_QT6)
# CMAKE_CXX_STANDARD 17 was added in CMake 3.8
set(CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard to use")
elseif(USE_BOOST AND USE_BOOST_INT128)
if(USE_BOOST AND USE_BOOST_INT128)
# Boost.Math requires C++14
set(CMAKE_CXX_STANDARD 14 CACHE STRING "C++ standard to use")
else()
Expand Down
Loading