Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'zip' gem conflicts with 'rubyzip' on Redmine XLS Export Plugin. #110

Merged
merged 1 commit into from Mar 28, 2013

Conversation

Projects
None yet
2 participants
@two-pack
Copy link
Contributor

commented Mar 28, 2013

What steps will reproduce the problem?

  1. Install DMSF Plugin and XLS Export Plugin.
    http://www.redmine.org/plugins/redmine_xls_export
  2. Do following because XLS Export Plugin needs Zip::ZipOutputStream::write_buffer.
    $ irb
    >> require 'zip/zip'
    => true
    >> p defined?(Zip::ZipOutputStream::write_buffer))
    => nil
    

What is the expected output? What do you see instead?

Now following issue is occurred. I wanna fix it.
two-pack/redmine_xls_export#19

What version of the product are you using? On what operating system?

Environment:

Redmine version 2.2.4.stable
Ruby version 1.8.7 (universal-darwin11.0)
Rails version 3.2.13
Environment development
Database adapter MySQL

Redmine plugins:

redmine_dmsf 1.4.5 stable
redmine_plugin_views_revisions 0.0.1
redmine_xls_export 0.2.1

Please provide any additional information below.

When loading init.rb in XLS Export, $: has paths of 'zip' and 'rubyzip'.
Index of 'zip' in $: is earlier then 'rubyzip'. And DSMF and XLS Export are same condition.
So 'zip' is loaded first, and same name library ISN'T loaded with require.

By the way, I checked DMSF with 'rubyzip', of course not all the things, maybe no problem.
I pull-request and want to change 'zip' to 'rubyzip' on your plugin if you can.

danmunn added a commit that referenced this pull request Mar 28, 2013

Merge pull request #110 from two-pack/master
'zip' gem conflicts with 'rubyzip' on Redmine XLS Export Plugin.

@danmunn danmunn merged commit 17a78e8 into danmunn:master Mar 28, 2013

1 check failed

default The Travis build could not complete due to an error
Details
@two-pack

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2013

Thanks quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.