Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent TCP server does not use smart responses #108

Open
urscion opened this Issue Mar 19, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@urscion
Copy link

urscion commented Mar 19, 2018

What OS?

  • Windows
  • Mac
  • [X ] Linux (CentOS 7)

Description of issue

When using a persistent TCP connection, the server does not use the smart responses more than once (after initial packet receive.) I believe this is because the processing loop does not call the writeResponse function after receiving a packet.

@dannagle dannagle self-assigned this Mar 19, 2018

@dannagle

This comment has been minimized.

Copy link
Owner

dannagle commented Mar 19, 2018

Just tested. Indeed, it does not.

I'm flagging this as "enhancement" until I decide what to do. My particular use requires that it does not repeat. If I need the response again, I'd reconnect. I am not sure what is preferred. The entire smart response engine could use some rework for the various open issues.

@urscion

This comment has been minimized.

Copy link
Author

urscion commented Mar 19, 2018

Ok, no worries. I have it changed locally for my use case so if i get desperate I can either work with you or submit a pull request myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.