Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

rewrote the ping logic to fix several ping related issues #9

Merged
merged 1 commit into from Nov 28, 2012

Conversation

Projects
None yet
1 participant
Owner

dannycoates commented Nov 28, 2012

The previous code would ping too frequently and could get stuck
in a ping loop, even if the endpoint was actually healthy.

The new code factors out the ping logic into its own module. The
logic for setting the endpoint health has be constrained to exactly
two locations, one for setting as healthy and one for unhealthy.

Pinger ensures that only one ping request is pending at a given time
and that the ping loop is independent of other timeouts. The pinger
uses exponential backoff for timing ping requests with a maximum
delay of 10s.

The tests were updated for the new behavior.

@dannycoates dannycoates rewrote the ping logic to fix several ping related issues
The previous code would ping too frequently and could get stuck
in a ping loop, even if the endpoint was actually healthy.

The new code factors out the ping logic into its own module. The
logic for setting the endpoint health has be constrained to exactly
two locations, one for setting as healthy and one for unhealthy.

Pinger ensures that only one ping request is pending at a given time
and that the ping loop is independent of other timeouts. The pinger
uses exponential backoff for timing ping requests with a maximum
delay of 10s.

The tests were updated for the new behavior.
594ce6c

@dannycoates dannycoates added a commit that referenced this pull request Nov 28, 2012

@dannycoates dannycoates Merge pull request #9 from dannycoates/stats
rewrote the ping logic to fix several ping related issues
56d5cb5

@dannycoates dannycoates merged commit 56d5cb5 into master Nov 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment