Skip to content

Danny Coates
dannycoates

Organizations

@mozilla @hapijs @node-inspector
May 19, 2016
@dannycoates

TBH I don't recall why we have this; @dannycoates do you? My memory of it was as a stop-gap anti-abuse measure to prevent an attacker from spammi…

May 18, 2016
dannycoates commented on pull request mozilla/fxa-auth-server#1263
@dannycoates

any preference? I'm fine with whatever, but I would support an effort to namespace events in general.

May 18, 2016
@dannycoates
May 18, 2016
dannycoates merged pull request dannycoates/able#18
@dannycoates
chore(package.json): update uglify-js and convict to latest versions
1 commit with 2 additions and 2 deletions
May 18, 2016
@dannycoates
Update convict and uglify-js dependencies
May 18, 2016
dannycoates commented on pull request dannycoates/able#18
@dannycoates

Thanks @TDA

May 17, 2016
@dannycoates
Parse android and ios Firefox Sync user agents
Apr 22, 2016
@dannycoates
  • @dannycoates 5405ac5
    feat(scripts): added admin scripts: block-ip and customs-info
Apr 22, 2016
@dannycoates
  • @dannycoates f69746b
    feat(scripts): added admin scripts: block-ip and customs-info
Apr 22, 2016
@dannycoates
feat(scripts): added admin scripts: block-ip and customs-info
1 commit with 127 additions and 0 deletions
Apr 22, 2016
Apr 22, 2016
@dannycoates
Apr 21, 2016
@dannycoates
Apr 21, 2016
@dannycoates
Remote zcarter pubkey :-(
1 commit with 0 additions and 1 deletion
Apr 21, 2016
@dannycoates
Apr 21, 2016
@dannycoates
Use correct name for PURGE_SOME_EXPIRED_ITEMS in mysql specific queries.
1 commit with 3 additions and 3 deletions
Apr 18, 2016
dannycoates commented on pull request mozilla/fxa-customs-server#109
@dannycoates

Thanks @jrgm! chmod +x ./scripts/config-set.js fixed

Apr 18, 2016
@dannycoates
  • @dannycoates 27d1ab9
    some *sharp* tools for updating the configs in memcache
Apr 18, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

The tokens are initialised together and they are verified together. Is it sufficient to only check the status of one of them for that reason? IMH…

Apr 18, 2016
@dannycoates
some *sharp* tools for updating the configs in memcache
1 commit with 178 additions and 1 deletion
Apr 18, 2016
Apr 17, 2016
@dannycoates
Apr 15, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

We have link expired errors for signup and password reset tokens Yeah, but those tokens actually expire. Do these? If not I don't think it makes …

Apr 15, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

nit: if we SELECT 1 or SELECT tokenId here I think this will be an index only query and faster

Apr 14, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

You could represent them explicitly with a row in the unverifiedTokens table that never gets deleted It doesn't seem that weird to me

Apr 14, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

How is one of these tokens-for-which-we-didn't-send-an-email represented in the db? Why do we need to distinguish them at all?

Apr 14, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

We only create unverified tokens But we don't always proactively send an email, like in the case of OAuth.

Apr 14, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

ok. I found the IRC conversation, so I understand the logic, but I still don't see why we need more than unverifiedTokens (tokenId, tokenVerificati…

Apr 14, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

1) Tokens that have been verified via email challenge 3) Tokens for which we did not send an email challenge at all Can you explain why we need t…

Apr 13, 2016
dannycoates commented on pull request mozilla/fxa-auth-db-mysql#132
@dannycoates

Should we handle 404? I think that depends on what we'd do with that information. If there's enough value in learning "this was already verified"…

Something went wrong with that request. Please try again.