Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Inconsistence in variable naming #57
Comments
|
Great, thanks! |
|
I'm looking to implement more changes to clean up the API in the near future FYI. buy and sell need some work to make their usage clear. |
|
Agreed. Thanks to everyone for your support. I'm closing this issue out. |
danpaquin
closed this
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bianjiang commentedJun 13, 2017
e.g.,
productId vs. product_id
orderId vs. order_id
A lot of places in the order are without the '_', while the GDAX api parameters are all with the underscore. This is somewhat confusing, especially the recent changes on the buy and sell function that takes raw GDAX api parameters.