typechecked islands - #33
Merged
Merged
Conversation
danprince
force-pushed
the
typechecked-islands
branch
from
February 12, 2023 08:26
a07eb18 to
dd446f8
Compare
danprince
force-pushed
the
typechecked-islands
branch
from
February 12, 2023 09:04
1a11fd8 to
0f53ed2
Compare
danprince
marked this pull request as ready for review
February 12, 2023 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There no type safety for the callsites of islands when they're written inside markdown as liquid shortcodes.
This PR translates all of the calls from the current build into actual TypeScript syntax and writes it to a
@check.tsfile that can be verified once the Eleventy build has finished.Important to change the build ordering so that
tscis called aftereleventyfrom now on.