How to create my own custom release of dygraphs? #759

Open
uriklar opened this Issue Jul 3, 2016 · 7 comments

Projects

None yet

2 participants

@uriklar
uriklar commented Jul 3, 2016

Hi all,
I had to make a change to dygraphs which fits a certain use case I have, but not fit for a PR... Now, I forked the repo and what i'm trying to do is have npm install dygraphs straight from my github account.

My problem is: I can't get my version of dygraphs to generate the neccesary files on npm install.
Currently my package.json simply has the line:

"dygraphs": "1.1.1" 

and everything works fine.

How can I make my fork work the same way?
Any help would be greatly appreciated!
Uri

@uriklar
uriklar commented Jul 11, 2016

Anyone? Someone must have done this before right?

@danvk
Owner
danvk commented Jul 11, 2016

Do you want the minified files? Build them locally and put them in your
github branch. You'll have to unignore them.
On Mon, Jul 11, 2016 at 7:22 AM Uri Klar notifications@github.com wrote:

Anyone? Someone must have done this before right?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#759 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAF__ToViImW2Pu8Oj_pdtbSNtbhcG9Zks5qUidbgaJpZM4JD2Sf
.

@uriklar
uriklar commented Jul 11, 2016 edited

How do I generate the files? I tried the various scripts, but I couldn't generate dygraphs-combined and dygraphs-combined-dev.
Also, are those the only two files needed? (I'm bundling with webpack)

@danvk
Owner
danvk commented Jul 11, 2016

npm run build

On Mon, Jul 11, 2016 at 8:23 AM Uri Klar notifications@github.com wrote:

Also, how do I generate the files? I tried the various scripts, but I
couldn't generate dygraphs-combined and dygraphs-combined-dev.
Also, are those the only two files needed? (I'm bundling with webpack)


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#759 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAF__fUVikewE_Lsgqq7z4YiUC-jMUiVks5qUjW2gaJpZM4JD2Sf
.

@uriklar
uriklar commented Jul 11, 2016

That generates dygraph-combined.js but no dygraph-combined-dev.js...

@danvk
Owner
danvk commented Jul 11, 2016

I don't think dygraph-combined-dev exists anymore. There's dist/dygraph.js and dist/dygraph.min.js.

@uriklar
uriklar commented Jul 12, 2016

@danvk I'm using webpack to bundle my app, and I am importing Dygraphs in the following manner:

import 'expose?Dygraph!dygraphs';
import 'dygraphs/extras/synchronizer.js';

In my webpack logs I see the loading occurs from dygraphs-combined-dev.

[268] ./~/expose-loader?Dygraph!./~/dygraphs/dygraph-combined-dev.js 130 bytes {0} [built]
[270] ./~/dygraphs/extras/synchronizer.js 6.24 kB {0} [built]

The dygraph-combined-dev is included in the dygraph package resulting in an npm install (version 1.1.1)

Any ideas what I could be doing wrong here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment