New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log along the x-axis (bug 189) #296

Merged
merged 4 commits into from May 29, 2014

Conversation

Projects
None yet
2 participants
@kberg
Collaborator

kberg commented Apr 23, 2014

No description provided.

Robert Konigsberg added some commits Apr 23, 2014

@kberg kberg changed the title from Log along the x-axis to Support log scale on the x axis Apr 23, 2014

@kberg kberg changed the title from Support log scale on the x axis to Log along the x-axis (bug 189) Apr 23, 2014

Show outdated Hide outdated dygraph-layout.js
@@ -175,6 +175,7 @@ DygraphLayout.prototype.setYAxes = function (yAxes) {
};
DygraphLayout.prototype.evaluate = function() {
this._xAxis = {};

This comment has been minimized.

@danvk

danvk Apr 23, 2014

Owner

Looks like most member vars have trailing underscores. I should really clean this up sometime.

@danvk

danvk Apr 23, 2014

Owner

Looks like most member vars have trailing underscores. I should really clean this up sometime.

This comment has been minimized.

@kberg

kberg Apr 24, 2014

Collaborator

ack. Agreed, and, no-op.

@kberg

kberg Apr 24, 2014

Collaborator

ack. Agreed, and, no-op.

Show outdated Hide outdated dygraph-layout.js
@@ -734,6 +734,14 @@ Dygraph.prototype.optionsViewForAxis_ = function(axis) {
if (axis_opts && axis_opts[axis] && axis_opts[axis].hasOwnProperty(opt)) {
return axis_opts[axis][opt];
}
// I don't like that this is in a second spot.

This comment has been minimized.

@danvk

danvk Apr 23, 2014

Owner

What is "this" here? It's not clear what the other location is that comment is referring to.

@danvk

danvk Apr 23, 2014

Owner

What is "this" here? It's not clear what the other location is that comment is referring to.

This comment has been minimized.

@kberg

kberg Apr 24, 2014

Collaborator

I didn't like repeating the special case of computing the logscale attribute for x-axes such that it ignores the global user-specified setting. I also don't like the optionsViewForAxis code either. :) Advice on code / comment?

@kberg

kberg Apr 24, 2014

Collaborator

I didn't like repeating the special case of computing the logscale attribute for x-axes such that it ignores the global user-specified setting. I also don't like the optionsViewForAxis code either. :) Advice on code / comment?

* (totally old values) and 1.0 (totally new values) for each frame.
* @private
*/
Dygraph.zoomAnimationFunction = function(frame, numFrames) {

This comment has been minimized.

@danvk

danvk Apr 23, 2014

Owner

I'm not sure why this is showing up in the diff -- did you move it?

@danvk

danvk Apr 23, 2014

Owner

I'm not sure why this is showing up in the diff -- did you move it?

This comment has been minimized.

@kberg

kberg Apr 24, 2014

Collaborator

I did. It was put smack dab in the middle of related methods.

@kberg

kberg Apr 24, 2014

Collaborator

I did. It was put smack dab in the middle of related methods.

@kberg

This comment has been minimized.

Show comment
Hide comment
@kberg

kberg May 10, 2014

Collaborator

ping!

Collaborator

kberg commented May 10, 2014

ping!

kberg added a commit that referenced this pull request May 29, 2014

Merge pull request #296 from danvk/xlog
Log along the x-axis (bug 189)

@kberg kberg merged commit ebf77a9 into master May 29, 2014

@kberg kberg deleted the xlog branch May 29, 2014

@danvk danvk restored the xlog branch Jun 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment