Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log along the x-axis (bug 189) #296

Merged
merged 4 commits into from May 29, 2014
Merged

Log along the x-axis (bug 189) #296

merged 4 commits into from May 29, 2014

Conversation

kberg
Copy link
Collaborator

@kberg kberg commented Apr 23, 2014

No description provided.

Robert Konigsberg added 2 commits Apr 23, 2014
@kberg kberg changed the title Log along the x-axis Support log scale on the x axis Apr 23, 2014
@kberg kberg changed the title Support log scale on the x axis Log along the x-axis (bug 189) Apr 23, 2014
context.dateRange = xRange[1] - xRange[0];
context.initialLeftmostDate = xRange[0];

if (g.getOptionForAxis("logscale", 'x')) {
Copy link
Owner

@danvk danvk Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quotes? double quotes?

Copy link
Collaborator Author

@kberg kberg Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What, you don't appreciate art? Fixed.

@@ -207,6 +212,14 @@ DygraphLayout.prototype._evaluateLimits = function() {
}
};

DygraphLayout.calcXNormal_ = function(value, axis, logscale) {
Copy link
Owner

@danvk danvk Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is DygraphAxisType really DygraphYAxisType? This code is duplicated and I'm not sure that it needs to be.

Copy link
Collaborator Author

@kberg kberg Apr 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you referring to?

The code needs to be duplicated because of the x-prefixes. Also, I wouldn't stress too much over five duplicate lines, though I agree clean-up would be nice.

@kberg
Copy link
Collaborator Author

kberg commented May 10, 2014

ping!

kberg added a commit that referenced this pull request May 29, 2014
Log along the x-axis (bug 189)
@kberg kberg merged commit ebf77a9 into master May 29, 2014
@kberg kberg deleted the xlog branch May 29, 2014
@danvk danvk restored the xlog branch Jun 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants