Fast Fill #462
Merged
Fast Fill #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (var i = 0; i < pendingActions.length - 1; /* incremented internally */) { | ||
| var action = pendingActions[i]; | ||
| if (action[0] == MOVE_TO && pendingActions[i + 1][0] == MOVE_TO) { | ||
| pendingActions.splice(i, 1); |
There was a problem hiding this comment.
Fascinating that these splices are fast.
There was a problem hiding this comment.
As it turns out, JavaScript is pretty fast these days!
That's changed substantially since dygraphs started. Working w/ ReactJS has really changed my mentality. Everything that's done in pure-JS land is fast. Everything that touches the DOM is slow.
|
I get the basics here, LGTM, but I can't do a detailed review. :/ |
This is done by introducing a "fast canvas proxy", which elides redundant moveTo and lineTo calls. This also reworks the order in which the points are drawn to be more amenable to this optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346
There are two main "innovations" here:
I took screenshots of
tests/dense-fill.htmlboth with and without the optimization. There were a few differences with the antialiasing along the edges, but nothing visually distinguishable.The performance improvement can be dramatic. For a 10,000 point series in a 480x320 chart (i.e. the benchmark), I see a drop from ~700ms/draw → 25ms/draw, which is roughly in line with the performance w/o
fillGraphset.The speedup is entirely explained by the number of line segments being sent to the canvas.
tests/dense-fill.htmldraws a 10,000 point series on an 800px wide canvas. Before, it issued 40,000moveToandlineTocalls. After, it issues ~1490.