Fix longstanding milliseconds bug #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestamp seconds to milliseconds conversion was adding the part after the . (which is a 6 figure number) and which was polluting the seconds part by adding as much as 16 minutes (max 999 seconds) to the timestamp.
Since Qt is not having a microsecond datetime, for now I just use the first 3 figures after the dot, and drop the rest.
(Previous text)
(not tested yet on master, only on feature/storage branch, I have a dbus build problem but pretty sure this is 5+years bug in that code)
I ended up running manually into src
qdbusxml2cpp -c SailslackAdaptor -a sailslack_adaptor.h:sailslack_adaptor.cpp harbour.sailslack.xml.Tested on master now too