-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version information required for pip install #39
Comments
@SpaceyCaseyLynn I think the issue should be fixed now, but I couldn't reproduce it exactly on my system. Could you see if my changes have fixed the issue? To do so, run the following code in your terminal,
This will clone my 'fixed' version of You may continue following installation instructions with my fixed version of |
Thanks for letting me know @SpaceyCaseyLynn. Just got back from vacation so only just saw this. I will try and reproduce this soon and get back to you. |
Unfortunately, I cannot reproduce your error message. Could you attach the output of In the meantime, you could try |
Hi Ashley,
I eventually fixed this with a few different steps:
1. I installed an older version of Isoclassify linked here that didn't
have the same automatic installation of dependencies
https://github.com/danxhuber/isoclassify/tree/a900b0b983e46ca31dd96d2beaa19478e4319959
2. I had to make sure that I directed my terminal to the correct install
(had an old install from the exoplanets class we took) so this involved
finding/editing/sourcing the right .bashrc file.
Hope these help!
~Casey
…On Thu, Nov 9, 2023 at 12:14 PM Ashley Chontos ***@***.***> wrote:
I tried another fresh install and I think the issue may be with how the
setup function is defined because it installs copies of the
isoclassify.direct and isoclassify.grid folders in the source directory
(see attached). Presumably this is confusing the software with where to
look for specific packages (the egg info is also saving within the source
directory too):
[image: Screenshot 2023-11-09 at 5 12 58 PM]
<https://urldefense.com/v3/__https://user-images.githubusercontent.com/13820495/281896000-abce23b4-cc5c-47fd-9360-bd71082d07fd.png__;!!PvDODwlR4mBZyAb0!T-2qUnGGLbeRro6a-HnFmRfnRlhWKG3mIpYtH2YrgaO1XWQT5zSwi4UuwpiPzZS0rybqqiJCSWQjYkWYTnruFS7VNRM$>
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/danxhuber/isoclassify/issues/39*issuecomment-1804766412__;Iw!!PvDODwlR4mBZyAb0!T-2qUnGGLbeRro6a-HnFmRfnRlhWKG3mIpYtH2YrgaO1XWQT5zSwi4UuwpiPzZS0rybqqiJCSWQjYkWYTnruPKOZbzo$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANRXDERID2ZP7CFFV2OOEVDYDVIURAVCNFSM6AAAAAA3D5XSNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUG43DMNBRGI__;!!PvDODwlR4mBZyAb0!T-2qUnGGLbeRro6a-HnFmRfnRlhWKG3mIpYtH2YrgaO1XWQT5zSwi4UuwpiPzZS0rybqqiJCSWQjYkWYTnruMfjupBg$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey Case, I'm glad you figured out a temporary hack to get it working on your computer! I was mostly pointing this out so it can hopefully be fixed in newer updates/versions i.e. so you don't have to have your computer point to an older version. The setup function defines the console point, so I actually didn't even have the Ashley |
Sounds good!
…On Thu, Nov 9, 2023 at 12:28 PM Ashley Chontos ***@***.***> wrote:
Hey Case,
I'm glad you figured out a temporary hack to get it working on your
computer!
I was mostly pointing this out so it can hopefully be fixed in newer
updates/versions i.e. so you don't have to have your computer point to an
older version. The setup function defines the console point, so I actually
didn't even have the ISOCLASSIFY environment defined in the bashrc (for
me, zsh) file (since this really should be avoided anyway). In the
meantime, I'll use the older version you linked so I can at least get some
stellar parameters :)
Ashley
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/danxhuber/isoclassify/issues/39*issuecomment-1804782531__;Iw!!PvDODwlR4mBZyAb0!U48qe6o3cJPXUVSfgkGRUoVWGe3qM955H3BeawVTpFfCHAFIn3-F2Q52CHsXjVf0C3Ax78CX7325JSriZM6vkyh6g0M$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANRXDEXS3PNYPF4QKBHT4WTYDVKI5AVCNFSM6AAAAAA3D5XSNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUG44DENJTGE__;!!PvDODwlR4mBZyAb0!U48qe6o3cJPXUVSfgkGRUoVWGe3qM955H3BeawVTpFfCHAFIn3-F2Q52CHsXjVf0C3Ax78CX7325JSriZM6vzi4zJTE$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for the update @ashleychontos and @SpaceyCaseyLynn! I can look into potential fixes for this. If either of you want a go at fixing instead feel free and let me know, I'm happy to help where possible! |
I still cannot reproduce the error, but have an idea of why you both might be seeing it. Did you clone the isoclassify repo directly into your Try cloning the repo somewhere else (e.g. directly into your home directory). Then go through the install instructions. If I'm wrong or that doesn't work let me know and I'll keep digging! If we add the package to PyPI then you can just pip install it without cloning the repository and that will stop this from happening. P.S. if this fixes the issue I'll suggest updating the REAME to be clearer |
Ok so I did what you suggested and it works now, but there are still two copies on my computer. I deleted the local copy and it appears that the command-line help is still working -> which bring me to my final question: It seems like you've already put in the actual work to easily make this possible, so why not make it pip-installable to prevent people from having to make the two copies on their computer? Either way, thanks for helping me out. I agree having something about not running it from python site-packages would be helpful.... as someone who used to be very bad at keeping python packages in one place (and now religiously does it). I thought I was doing the right thing by cloning it there only to make things worse! |
Absolutely, that would be great! I am not the repository maintainer so would need to run this by @danxhuber. This involves uploading the package to PyPI. Ideally, it would be uploaded after Dan or another maintainer merges PR #40 (the version number fix), as I don't have permission to merge it. If you just ran
You're welcome! Yeah, it can get messy very quickly, especially if using virtual environment or |
Thanks all, this has now been implemented and the code is pip-installable. |
It appears pip requires version info to install. The setup.py script sets
version=None
which no longer works.Problem
Originally posted by @SpaceyCaseyLynn in #30 (comment)
Solution
Set
version
insetup.py
.This is an easy fix, I'm on it!
The text was updated successfully, but these errors were encountered: