From eb3d39fe344c1381024d899b372d04f0adae1652 Mon Sep 17 00:00:00 2001
From: roienatan <34843014+roienatan@users.noreply.github.com>
Date: Sun, 6 Sep 2020 09:45:05 +0300
Subject: [PATCH] added default value and placeholder (#2091)

* added default value and placeholder

* removed default value

* added dafualt value back

* data field is now optional with default value

* change text in placeholder
---
 .../PluginForms/CreateKnownGenericPluginProposal.tsx       | 7 +++++--
 src/genericPluginRegistry/plugins/NFTManager.json          | 4 +++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/components/Proposal/Create/PluginForms/CreateKnownGenericPluginProposal.tsx b/src/components/Proposal/Create/PluginForms/CreateKnownGenericPluginProposal.tsx
index 65dcb4101..a9d8f56c8 100644
--- a/src/components/Proposal/Create/PluginForms/CreateKnownGenericPluginProposal.tsx
+++ b/src/components/Proposal/Create/PluginForms/CreateKnownGenericPluginProposal.tsx
@@ -171,7 +171,10 @@ class CreateKnownPluginProposal extends React.Component<IProps, IState> {
     const callValues = [];
 
     for (const field of currentAction.getFields()) {
-      const callValue = field.callValue(values[field.name]);
+      let callValue = field.callValue(values[field.name]);
+      if (!callValue && field.defaultValue){
+        callValue = field.defaultValue;
+      }
       values[field.name] = callValue;
       callValues.push(callValue);
     }
@@ -380,7 +383,7 @@ class CreateKnownPluginProposal extends React.Component<IProps, IState> {
                 }
 
                 if (field.type.includes("bytes")) {
-                  if (!isHexString(value)) {
+                  if (value && !isHexString(value)) {
                     errors[field.name] = "Must be a hex value";
                   }
                 }
diff --git a/src/genericPluginRegistry/plugins/NFTManager.json b/src/genericPluginRegistry/plugins/NFTManager.json
index 92e2b2e32..82bd7cab8 100644
--- a/src/genericPluginRegistry/plugins/NFTManager.json
+++ b/src/genericPluginRegistry/plugins/NFTManager.json
@@ -30,7 +30,9 @@
           {
             "label": "Data",
             "name": "data",
-            "placeholder": ""
+            "placeholder": "Arbitrary data to transfer (0x0 means no data)",
+            "defaultValue": "0x0",
+            "optional": true
           }
         ],
         "abi": {