Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WinUI #37

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Conversation

AliveDevil
Copy link
Contributor

For the samples following applies:

As the regular implementation does not depend on WinUI (only the nuget package for references) I don't think this requires any knowledge of WinUI/Project Reunion/Windows App SDK

Implements #29

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2021

CLA assistant check
All committers have signed the CLA.

@Lakritzator Lakritzator changed the base branch from master to feature/WinUI October 3, 2021 14:11
@Lakritzator
Copy link
Member

I created a new branch (feature/WinUI), and targeted this PR to it, which allows us to play with it before putting it into master.

@AliveDevil AliveDevil marked this pull request as ready for review October 15, 2021 17:21
@AliveDevil
Copy link
Contributor Author

From my side there is nothing to be added here.
It Works™️ for now, doesn't crash on my side with this code.
Will need revision for Windows App SDK 1.0.

@Lakritzator
Copy link
Member

Ok, cool, I will try it out as soon I as have some time.

@kevinchalet
Copy link

That would be awesome to see this PR merged ❤️‍🔥

@AliveDevil
Copy link
Contributor Author

That would be awesome to see this PR merged ❤️‍🔥

I’ll see that I get it up to date and working next week.

AliveDevil and others added 6 commits January 25, 2023 11:03
* Separately packaged
* Single project package
Keep reference open for AppWindow.
DispatcherQueue needs to be assigned in Application.Start
@AliveDevil
Copy link
Contributor Author

Updated to latest stable WindowsAppSdk 1.2 (instead of ProjectReunion), included net6 as well (WAppSdk requires at least net6-windows10.0.17763).
Tried starting any of the Packaged-projects (separate Packaging-project & Single-Packaged Project).

@Lakritzator anything left for this to get testing done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants