Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi App Run: Move log destination fields for daprd and apps to common section #1293

Closed
pravinpushkar opened this issue May 26, 2023 · 1 comment · Fixed by #1294
Closed

Multi App Run: Move log destination fields for daprd and apps to common section #1293

pravinpushkar opened this issue May 26, 2023 · 1 comment · Fixed by #1294
Assignees
@pravinpushkar
Labels
kind/bug Something isn't working
Milestone
v1.11

Comments

@pravinpushkar
Copy link
Contributor

pravinpushkar commented May 26, 2023 •
edited
Loading

Expected Behavior

I should be able to put daprdLogDestination and appLogDestination in the common section like below -

version: 1
common:
  daprdLogDestination: file
  appLogDestination: file
apps:

Actual Behavior

Currently I can only specify in the app's section -

version: 1
common:
apps:
 - appID: frontendapp
   daprdLogDestination: file
   appLogDestination: file

Release Note

RELEASE NOTE:
@pravinpushkar pravinpushkar added the kind/bug Something isn't working label May 26, 2023
@pravinpushkar pravinpushkar changed the title Multi App RunMove log destination fields for daprd and apps Multi App Run: Move log destination fields for daprd and apps to common section May 26, 2023
@pravinpushkar pravinpushkar mentioned this issue May 26, 2023
Merged
@mukundansundar mukundansundar added this to the v1.11 milestone May 26, 2023
@mukundansundar
Copy link
Collaborator

closed via #1294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pravinpushkar pravinpushkar

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

Move log destination flag to sharedRunConfig pravinpushkar/cli
2 participants
@pravinpushkar @mukundansundar