Skip to content

Adding output binding for commercetools#1652

Merged
berndverst merged 9 commits into
dapr:masterfrom
harrykimpel:binding_commercetools
Apr 12, 2022
Merged

Adding output binding for commercetools#1652
berndverst merged 9 commits into
dapr:masterfrom
harrykimpel:binding_commercetools

Conversation

@harrykimpel
Copy link
Copy Markdown
Contributor

Description

Adding output binding for commercetools.

Issue reference

n/a

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@harrykimpel harrykimpel requested review from a team as code owners April 8, 2022 12:24
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel harrykimpel force-pushed the binding_commercetools branch from 3c5e5e1 to 47cdbcd Compare April 8, 2022 12:25
@berndverst
Copy link
Copy Markdown
Member

I assume this is a continuation of the work in PR -- #1224

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst berndverst self-assigned this Apr 8, 2022
@berndverst berndverst added this to the v1.8 milestone Apr 8, 2022
@berndverst
Copy link
Copy Markdown
Member

LGTM

Please complete the docs PR for this -- I opened a docs issue for you. dapr/docs#2351

I will merge this once the docs PR has been opened.

@berndverst berndverst added do-not-merge PR is not ready for merging documentation required This issue needs documentation labels Apr 8, 2022
@harrykimpel
Copy link
Copy Markdown
Contributor Author

harrykimpel commented Apr 11, 2022

@berndverst
Copy link
Copy Markdown
Member

@harrykimpel my bad :) Fantastic, I'll merge this then!

@berndverst berndverst removed do-not-merge PR is not ready for merging documentation required This issue needs documentation labels Apr 12, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2022

Codecov Report

Merging #1652 (755d34d) into master (850e58d) will decrease coverage by 0.09%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
- Coverage   36.39%   36.29%   -0.10%     
==========================================
  Files         163      164       +1     
  Lines       15342    15419      +77     
==========================================
+ Hits         5583     5597      +14     
- Misses       9150     9207      +57     
- Partials      609      615       +6     
Impacted Files Coverage Δ
bindings/commercetools/commercetools.go 18.18% <18.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0b7a0...755d34d. Read the comment docs.

@berndverst berndverst merged commit 61ff304 into dapr:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants