Add Feishu Webhook Binding #872
Conversation
|
|
| if loaded { | ||
| return fmt.Errorf("feishu webhook error: duplicate id %s", t.settings.ID) | ||
| } | ||
| webhooks.m[t.settings.ID] = &outgoingWebhook{handler: handler} |
There was a problem hiding this comment.
It looks like Read (Input Binding method) must be called for a webhook to be created so that Invoke with GetOperation (Output Binding method) can be called to retrieve a message . I don't think input bindings and output bindings are supposed to share state like this. Is there a reason why you set it up this way? Maybe we can recommend a different approach that fits into the model.
/cc: @artursouza @mukundansundar Thoughts?
There was a problem hiding this comment.
Any reason why this cannot go to Init()?
There was a problem hiding this comment.
Looks like this was borrowed from the DingTalk component and the same questions apply to that component.
https://github.com/dapr/components-contrib/blob/master/bindings/alicloud/dingtalk/webhook/webhook.go#L88-L101
There was a problem hiding this comment.
@pkedy @artursouza yes, it copied from DingTalk component, I will update this later
|
ping @ipfans |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Description
A binding that allows reading / writing from Feishu webhook. Feishu is a team collaborate toolkit developed by ByteDance.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #871
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: