Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Dapr API calls #4119

Closed
artursouza opened this issue Jan 11, 2022 · 9 comments · Fixed by #4288 or dapr/cli#903
Closed

Log Dapr API calls #4119

artursouza opened this issue Jan 11, 2022 · 9 comments · Fixed by #4288 or dapr/cli#903
Assignees
Labels
Milestone

Comments

@artursouza
Copy link
Member

artursouza commented Jan 11, 2022

In what area(s)?

On every call into the Sidecar or into the App, a log message should be printed for both gRPC and HTTP. I propose this to be have DEBUG verbosity.

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Describe the feature

Display API calls to/from Dapr sidecar.

Release Note

RELEASE NOTE: ADDED logging for Dapr API calls

@artursouza artursouza added this to the v1.7 milestone Jan 11, 2022
@artursouza artursouza added pinned P1 size/S 1 week of work triaged/resolved Indicates that this issue has been triaged labels Jan 11, 2022
@yaron2
Copy link
Member

yaron2 commented Jan 11, 2022

This was discussed in the past and decided against. It's way too verbose and doesn't provide any value. We currently log API calls on Debug level.

Info would create an IO bottleneck, degrade performance and create noisy output for user's log sinks.

@yaron2 yaron2 removed triaged/resolved Indicates that this issue has been triaged pinned labels Jan 11, 2022
@yaron2
Copy link
Member

yaron2 commented Jan 11, 2022

Removed from 1.7 until further discussed.

@yaron2
Copy link
Member

yaron2 commented Jan 11, 2022

@artursouza please update the proposal to Debug verbosity, then we can put in 1.7 as we'll have consensus.

@yaron2
Copy link
Member

yaron2 commented Jan 11, 2022

As for the implementation, ideally this can be accomplished as a global HTTP handler for the HTTP API and as a gRPC interceptor for gRPC, instead of per endpoint/method.

@yaron2 yaron2 removed this from the v1.7 milestone Jan 11, 2022
@artursouza
Copy link
Member Author

@yaron2 @msfussell would it make sense to have this log level configurable with DEBUG as default, so some developers might want to have this at INFO and not DEBUG where the performance hit is not critical to their application. I am saying this because I have many past experiences where logging API calls were set as INFO and critical to debug production issues. Changing to DEBUG to force the API log output after the fact of the incident would not add value.

@yaron2
Copy link
Member

yaron2 commented Jan 11, 2022

@yaron2 @msfussell would it make sense to have this log level configurable with DEBUG as default, so some developers might want to have this at INFO and not DEBUG where the performance hit is not critical to their application. I am saying this because I have many past experiences where logging API calls were set as INFO and critical to debug production issues. Changing to DEBUG to force the API log output after the fact of the incident would not add value.

Fine by me.

@yaron2 yaron2 added this to the v1.7 milestone Jan 11, 2022
@artursouza
Copy link
Member Author

/cc @amulyavarote

@amulyavarote
Copy link
Contributor

/assign

@msfussell
Copy link
Member

@amulyavarote - can you create a docs issue for this to track. The docs issues should contain examples on how to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants