New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Dapr API calls #4119
Comments
This was discussed in the past and decided against. It's way too verbose and doesn't provide any value. Info would create an IO bottleneck, degrade performance and create noisy output for user's log sinks. |
Removed from 1.7 until further discussed. |
@artursouza please update the proposal to |
As for the implementation, ideally this can be accomplished as a global HTTP handler for the HTTP API and as a gRPC interceptor for gRPC, instead of per endpoint/method. |
@yaron2 @msfussell would it make sense to have this log level configurable with DEBUG as default, so some developers might want to have this at INFO and not DEBUG where the performance hit is not critical to their application. I am saying this because I have many past experiences where logging API calls were set as INFO and critical to debug production issues. Changing to DEBUG to force the API log output after the fact of the incident would not add value. |
Fine by me. |
/cc @amulyavarote |
/assign |
@amulyavarote - can you create a docs issue for this to track. The docs issues should contain examples on how to use this. |
In what area(s)?
On every call into the Sidecar or into the App, a log message should be printed for both gRPC and HTTP. I propose this to be have DEBUG verbosity.
Describe the feature
Display API calls to/from Dapr sidecar.
Release Note
RELEASE NOTE: ADDED logging for Dapr API calls
The text was updated successfully, but these errors were encountered: