Env variables inconsistency #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

msfussell merged 19 commits into dapr:v1.4 from anhldbk:issue-1781-env-variables-inconsistency

Oct 20, 2021

Contributor

anhldbk commented Oct 3, 2021 •

edited

Loading

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

Read the contribution guide
Commands include options for Linux, MacOS, and Windows within codetabs
New file and folder names are globally unique
Page references use shortcodes instead of markdown or URL links
Images use HTML style and have alternative text
Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

PR to remove unnecessary env variables

Issue reference

anhldbk added 3 commits

October 3, 2021 17:48


          Remove uncessary env variables

ef32eac

ISSUE-1781


          Remove unnecessary env variables

dd4a033

ISSUE-1781


          Merge branch 'issue-1781-env-variables-inconsistency' of https://gith…

e45014a

…ub.com/anhldbk/docs into issue-1781-env-variables-inconsistency

anhldbk requested review from a team as code owners

October 3, 2021 10:53

anhldbk changed the title ~~Env variables inconsistency~~ WIP: Env variables inconsistency


          Merge branch 'v1.4' into issue-1781-env-variables-inconsistency

f9eca19

Contributor Author

anhldbk commented Oct 3, 2021

@artursouza PTAL

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Show resolved Hide resolved

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Show resolved Hide resolved

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved


          Update env variables in other sections

81cfc85

- Remove outdated env variables
- Docs are re-formatted for readability

ISSUE-1781

anhldbk changed the title ~~WIP: Env variables inconsistency~~ Env variables inconsistency


          Merge branch 'v1.4' into issue-1781-env-variables-inconsistency

da3c8df

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/cli/dapr-run.md Outdated Show resolved Hide resolved

anhldbk added 3 commits

October 7, 2021 07:51


          run command: remove arg placement-host-address

7c898fb

ISSUE-1781


          Merge branch 'issue-1781-env-variables-inconsistency' of https://gith…

2a7c0ef

…ub.com/anhldbk/docs into issue-1781-env-variables-inconsistency


          Env: rename dapr runtime into dapr sidecar

b28ada7

ISSUE-1781

Contributor Author

anhldbk commented Oct 7, 2021

@msfussell May be not related. IMHO

sub-command docs have verbose headers.
we have weirdly large headers also

Can I modify them a little bit? Like this

Member

msfussell commented Oct 11, 2021 •

edited

Loading

@msfussell May be not related. IMHO

sub-command docs have verbose headers.

we have weirdly large headers also

Can I modify them a little bit? Like this

For these

sub-command docs have verbose headers - "Dapr" should not be included in the title. We stay away from putting Dapr in all the titles. You can just shorted this to just "run" in lower case, as opposed to "run CLI command reference"
we have weirdly large headers also - Yes, these sub headings can be H3 headings to make them smaller, as you point out

anhldbk commented

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved

daprdocs/content/en/reference/environment/_index.md Show resolved Hide resolved

daprdocs/content/en/reference/cli/dapr-run.md Outdated Show resolved Hide resolved

daprdocs/content/en/reference/cli/dapr-run.md Outdated Show resolved Hide resolved

daprdocs/content/en/reference/environment/_index.md Show resolved Hide resolved

anhldbk added 4 commits

October 11, 2021 21:16


          cli: resolve complains by MarkDown linter

8b1bfba


          cli: smaller headers

bbe1dd4


          cli: remove verbose .lead element

7188b35


          readme: fix styles

8e110c2

Contributor Author

anhldbk commented Oct 11, 2021

@msfussell I updated the styling also ;) Please check it out.

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/cli/dapr-init.md Outdated Show resolved Hide resolved

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/cli/dapr-init.md Outdated Show resolved Hide resolved

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/cli/dapr-run.md Show resolved Hide resolved

anhldbk added 3 commits

October 15, 2021 08:23


          Dapr Init: update examples to use latest version

f2ad051


          Dapr run: add example for Go

d7d5241


          Env: update components using APP_API_TOKEN

b4b16f9

Member

msfussell commented Oct 15, 2021

Changes look great.

Contributor Author

anhldbk commented Oct 15, 2021

@msfussell So I've done with this PR, right?

Member

msfussell commented Oct 19, 2021

Yes. This PR is done.

msfussell approved these changes

View reviewed changes

Member

msfussell left a comment

Changes LGTM


          Merge branch 'v1.4' into issue-1781-env-variables-inconsistency

c7a37af

Contributor Author

anhldbk commented Oct 19, 2021

@msfussell You made my day. Thank you!

anhldbk requested a review from msfussell

October 19, 2021 07:14

msfussell reviewed

View reviewed changes

daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved

anhldbk added 2 commits

October 20, 2021 08:56


          env: update usage for APP_API_TOKEN

9d14aa2


          Merge branch 'issue-1781-env-variables-inconsistency' of https://gith…

d12738f

…ub.com/anhldbk/docs into issue-1781-env-variables-inconsistency

msfussell merged commit 9ddab5d into dapr:v1.4

anhldbk deleted the issue-1781-env-variables-inconsistency branch

October 20, 2021 13:54

anhldbk mentioned this pull request

Correct env variables passed to child applications dapr/cli#770

Closed

4 tasks

anhldbk mentioned this pull request

Run: pass missing env variables dapr/cli#860

Merged

4 tasks

anhldbk mentioned this pull request

Environment variables: Sync with the latest doc dapr/python-sdk#350

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet