From f9814bb2c32afc9967f07fde3cf73c04b4de2c3a Mon Sep 17 00:00:00 2001 From: salaboy Date: Wed, 28 May 2025 12:43:04 +0100 Subject: [PATCH 1/2] fixing formatting in logs Signed-off-by: salaboy --- .../java/io/dapr/durabletask/TaskOrchestrationExecutor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java b/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java index 7191ebb8..f03e68c2 100644 --- a/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java +++ b/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java @@ -1188,7 +1188,7 @@ private boolean shouldRetry() { } private boolean shouldRetryBasedOnPolicy() { - logger.warning(this.attemptNumber + " retries out of total %d performed " + this.policy.getMaxNumberOfAttempts()); + logger.warning(() -> String.format(this.attemptNumber + " retries out of total %d performed " + this.policy.getMaxNumberOfAttempts())); if (this.attemptNumber >= this.policy.getMaxNumberOfAttempts()) { // Max number of attempts exceeded From 7e66abbb9587fec161ba2171ef681cf0917b9948 Mon Sep 17 00:00:00 2001 From: salaboy Date: Wed, 28 May 2025 14:15:54 +0100 Subject: [PATCH 2/2] Update client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java Co-authored-by: Javier Aliaga Signed-off-by: salaboy --- .../java/io/dapr/durabletask/TaskOrchestrationExecutor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java b/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java index f03e68c2..569cc717 100644 --- a/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java +++ b/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java @@ -1188,7 +1188,7 @@ private boolean shouldRetry() { } private boolean shouldRetryBasedOnPolicy() { - logger.warning(() -> String.format(this.attemptNumber + " retries out of total %d performed " + this.policy.getMaxNumberOfAttempts())); + logger.warning(() -> String.format("%d retries out of total %d performed ", this.attemptNumber, this.policy.getMaxNumberOfAttempts())); if (this.attemptNumber >= this.policy.getMaxNumberOfAttempts()) { // Max number of attempts exceeded