Skip to content

Proposal: Unify the DAPR_API_TOKEN env variable across all SDKs #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2023
Merged

Proposal: Unify the DAPR_API_TOKEN env variable across all SDKs #38

merged 2 commits into from
Oct 25, 2023

Conversation

@elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Sep 18, 2023

No description provided.

@elena-kolevska
Proposal: Unify the DAPR_API_TOKEN env variable across all SDKs
9632adc 
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@artursouza
Copy link
Contributor

artursouza commented Sep 18, 2023

+1 binding

2 similar comments
@mukundansundar
Copy link
Contributor

mukundansundar commented Sep 18, 2023

+1 binding

@yaron2
Copy link
Member

yaron2 commented Sep 18, 2023

+1 binding

@artursouza
Copy link
Contributor

artursouza commented Sep 18, 2023

@elena-kolevska Please, update your commit with "-s"

@elena-kolevska
Copy link
Contributor Author

elena-kolevska commented Sep 18, 2023

@artursouza I thought I did. I do see "Signed-off-by: Elena Kolevska elena@kolevska.com" and the DCO check is passing. Am I missing anything?

@shubham1172
Copy link
Member

shubham1172 commented Sep 18, 2023

+1 binding

1 similar comment
@berndverst
Copy link
Member

berndverst commented Sep 18, 2023

+1 binding

@artursouza
Copy link
Contributor

artursouza commented Sep 19, 2023

@artursouza I thought I did. I do see "Signed-off-by: Elena Kolevska elena@kolevska.com" and the DCO check is passing. Am I missing anything?

This might be a wrong requirement in this repo that is asking for cryptographically signed commits. Let me remove that since we don't have that requirement anywhere. Thanks.

@elena-kolevska elena-kolevska mentioned this pull request Sep 19, 2023
Closed
4 tasks
@kendallroden
Copy link

kendallroden commented Oct 23, 2023

Agree this will really help standardize the SDKs and remove confusion for customers on proper client initialization requirements +1

@elena-kolevska
Copy link
Contributor Author

elena-kolevska commented Oct 25, 2023

Thanks everyone. Can we proceed to merging this?

@yaron2
Copy link
Member

yaron2 commented Oct 25, 2023

Thanks everyone. Can we proceed to merging this?

Yes, this proposal can be merged now.

@yaron2 yaron2 merged commit 6638cff into dapr:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@artursouza artursouza artursouza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@elena-kolevska @artursouza @mukundansundar @yaron2 @shubham1172 @berndverst @kendallroden