Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups for JS crypto quickstart #883

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fixups for JS crypto quickstart #883

merged 2 commits into from
Jun 15, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle commented Jun 13, 2023 •
edited
Loading

2 fixes for JS crypto quickstart:

  1. Updated the JS SDK to 3.1.1 to fix an issue that was detected in the tests in this repo (Fixed handling of backpressure in DaprChunkedStream js-sdk#503)
  2. Fixed 2 typos in output

@ItalyPaleAle
Copy link
Contributor Author

I believe the bug is actually in the JS SDK and this will fix it: dapr/js-sdk#503

Will update this PR once a new SDK is released

@ItalyPaleAle
Fixups for JS crypto
5b37e32 
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
shubham1172
shubham1172 suggested changes Jun 14, 2023
View reviewed changes
Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. could you please use SDK v3.1.2?

@ItalyPaleAle
Updated SDK to 3.1.2
f2eb310 
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle
Copy link
Contributor Author

@shubham1172 updated to use 3.1.2. I also switched to the ~3.1.2 syntax so it will install updates up to 3.2.0 (not included) automatically

@shubham1172
Copy link
Member

@shubham1172 updated to use 3.1.2. I also switched to the ~3.1.2 syntax so it will install updates up to 3.2.0 (not included) automatically

Thanks a lot, @ItalyPaleAle!

paulyuk
paulyuk approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk paulyuk merged commit 7f3a91e into dapr:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1172 shubham1172 shubham1172 requested changes

@paulyuk paulyuk paulyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ItalyPaleAle @shubham1172 @paulyuk