Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template specializations to avoid shift warnings. #16

Merged
merged 2 commits into from Mar 5, 2019
Merged

Conversation

@LTLA
Copy link
Contributor

@LTLA LTLA commented Mar 5, 2019

May (or may not) address the segfault observed in #15.

@rstub
Copy link
Member

@rstub rstub commented Mar 5, 2019

It feels weird having to define these template specializations even though they will never be called. I tried to get rid of the compiler warnings using tag dispatch on shiftable. But the there was lots of code duplication between the true and falsecases.

@rstub
Copy link
Member

@rstub rstub commented Mar 5, 2019

BTW, since we know that these four template specializations will never be called, can you please add // # nocov to the end of those lines? that way the error from the codecov check should go away.

@rstub rstub merged commit 38cc4e6 into daqana:master Mar 5, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 94.11%)
Details
codecov/project 94.17% (+0.06%) compared to e5404aa
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.