Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flemming Harrington weights in `comp` #15

Closed
MarcinKosinski opened this issue Jan 29, 2017 · 2 comments
Closed

Flemming Harrington weights in `comp` #15

MarcinKosinski opened this issue Jan 29, 2017 · 2 comments

Comments

@MarcinKosinski
Copy link
Contributor

@MarcinKosinski MarcinKosinski commented Jan 29, 2017

Shouldn't {S(t_i)}^p *{1-S(t_i)}^q be the weight in the Flemming-Harrington test in comp?
So far it is written very confusingly in the documentation https://github.com/dardisco/survMisc/blob/master/R/comp.R#L95 - S(t[i - 1])^p * (1 - S(t)[i - 1]^q)

In my opinion the easier way to understand this would be {S(t_{i - 1})}^p * {1 - S(t_{i - 1})}^q In your formula q is in the bad position, [] - those brackets are misleading and I think there should be t_i instead of t_{i-1}.

@MarcinKosinski
Copy link
Contributor Author

@MarcinKosinski MarcinKosinski commented Jan 29, 2017

@dardisco do you maintain this package or this is rather unmaintained package?

@MarcinKosinski
Copy link
Contributor Author

@MarcinKosinski MarcinKosinski commented Feb 12, 2017

ok then leave it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.