Skip to content

Planets Overview#170

Merged
jacobrosenthal merged 13 commits intodarkforest-eth:masterfrom
Stx69:Stx69-patch-1
Oct 5, 2021
Merged

Planets Overview#170
jacobrosenthal merged 13 commits intodarkforest-eth:masterfrom
Stx69:Stx69-patch-1

Conversation

@Stx69
Copy link
Copy Markdown
Contributor

@Stx69 Stx69 commented Oct 2, 2021

Dear DF players,
here is other trial of my scripting... Feel free to use and give me feedback for future develop.

BR
Styx

Stx69 added 3 commits October 2, 2021 14:26
Dear all,
sharing my trial of Planets Overview plugin. In this times where time is against us...
Copy link
Copy Markdown
Contributor

@modukon modukon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly read through the code and tested it and it seems to work.

The code has some bad formatting (spaces and one large line)
but this can be easily fixed if you want: https://prettier.io/playground/
you can just copy paste your code into the site and it will format it for you.

It says "lid Da," for energy and silver time, not sure what it means.
Does the time tell you when it will be 100% ?

@Stx69
Copy link
Copy Markdown
Contributor Author

Stx69 commented Oct 3, 2021

yes you are right time say +- when will be full (via code 99%), and 'lid Da" is output string of function for not valid if I good understood.

Reformating form of code.
@Stx69
Copy link
Copy Markdown
Contributor Author

Stx69 commented Oct 4, 2021

Many thanks for your audit Sir. Will do it after a round...

Updated according feedback!
@Stx69
Copy link
Copy Markdown
Contributor Author

Stx69 commented Oct 4, 2021

I found short time to update.

@modukon
Copy link
Copy Markdown
Contributor

modukon commented Oct 4, 2021

There is an "Un. Trans" button, its not documented, it logs unconfirmed transactions to the console.
I dont know why it exist in this plugin, but whatever :D its fine for me

@Stx69
Copy link
Copy Markdown
Contributor Author

Stx69 commented Oct 4, 2021

oh, this is my hiden function to read whole data range. At console you can open and see all detailed information.... for example if you wanna do refresh and have a list of important moves...

Stx69 and others added 2 commits October 4, 2021 20:46
ehmmm old copy from local storage....

Co-authored-by: Jacob Rosenthal <jacobrosenthal@gmail.com>
Update of description done. Please review grama... Next will the format conversion 000 000 000 = K/M/G.
Co-authored-by: Jacob Rosenthal <jacobrosenthal@gmail.com>
Stx69 added 5 commits October 5, 2021 02:04
updated coments , nbrs formating k/m/b , final edit... I hope 👯
added buttons tittle.
After trial of some title's.  Added for all active elements. select lists , buttons , range slider, checkbox. 

Should be standard for plugins? Its most helpful and efficient way for newbie...
@jacobrosenthal jacobrosenthal merged commit 7ef4d20 into darkforest-eth:master Oct 5, 2021
@jacobrosenthal
Copy link
Copy Markdown
Contributor

Thanks for the plugin!
and thanks as always to @modukon for the reviews

@dudendy dudendy mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants