Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plugin: Highlight Friends #172

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Conversation

fromddy
Copy link
Contributor

@fromddy fromddy commented Oct 4, 2021

Circle your friends' planets with pink circles :)

@modukon
Copy link
Contributor

modukon commented Oct 4, 2021

hello!
I can see your screenshot is 458 kb big, i think the limit for screenshots is 50 kb
Take a look at this screenshot https://github.com/darkforest-eth/plugins/blob/master/content/productivity/highlight-buffs/screenshot.png
Its also big but has only 36.2 kb

@fromddy
Copy link
Contributor Author

fromddy commented Oct 4, 2021

thanks for your advice , do you know how to make picture smaller ? thanks very much .

@Bulmenisaurus
Copy link
Contributor

Bulmenisaurus commented Oct 4, 2021

thanks for your advice , do you know how to make picture smaller ? thanks very much .

You could probably scale it down to a smaller size.

Other plugins have screenshots of around 400x400px, so you could probably scale it down to that size

@fromddy
Copy link
Contributor Author

fromddy commented Oct 4, 2021

thanks very much, i will scale a small screenshot .

@Bulmenisaurus
Copy link
Contributor

Also tested it, and it works well :)

@Stx69
Copy link
Contributor

Stx69 commented Oct 4, 2021

for pic size I had same issue, do not use a simple paint.. I'm very satisfied with Greenshot.

Stx69
Stx69 previously approved these changes Oct 4, 2021
@Stx69
Copy link
Contributor

Stx69 commented Oct 4, 2021

Hello,
I really like the idea about friends.. :D Working well. What about add enemy (red) + neutral (white) ? Then will be nice full packet for visual plugin of diplomacy....

@fromddy fromddy force-pushed the master branch 2 times, most recently from daf91bc to cdcbb83 Compare October 5, 2021 09:46
@fromddy
Copy link
Contributor Author

fromddy commented Oct 5, 2021

  1. for the 'screenshot.png', I use Greenshot to get a new one.
  2. for the name of this plugin, I change name to [Highlight Friends].
  3. change 'window.planet' to 'window.HIGNLIGHT_FRIENDS.planet'.
  4. for the idea of 'add enemy (red) + neutral (white)', this is a good idea. actually, those players who are not circled may be dangerous.

thanks very much for all friends help and test.

Copy link
Contributor

@Stx69 Stx69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this one how example "how work with flag's of object". Registering to memory. etc...

@fromddy
Copy link
Contributor Author

fromddy commented Oct 5, 2021

@Stx69 thanks for your like for this plugin. With 'window.HIGHLIGHT_FRIENDS.planet', the state of plugin exists when the plugin is reopened. I learn this way in plugins that are published before.

@jacobrosenthal jacobrosenthal changed the title Add Plugin: Mark Friends Add Plugin: Highlight Friends Oct 5, 2021
@jacobrosenthal jacobrosenthal merged commit 2278238 into darkforest-eth:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants