Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update distribute-silver #60

Merged
merged 4 commits into from May 29, 2021
Merged

update distribute-silver #60

merged 4 commits into from May 29, 2021

Conversation

CremaFR
Copy link
Contributor

@CremaFR CremaFR commented May 28, 2021

Added maxAsteroidLevel param
Added send all to space rift
Added withdraw all from space rift
Changed planet to check for planet instead of not asteroid
Changed rejection limit from 1 to 5
Fixed planetResource to new API planetType

With the new maxAsteroidLevel we can increase the rejection limit to send all silvers from small mines to one big planet without risking loosing silvers.

Added maxAsteroidLevel param
Added send all to space rift
Added withdraw all from space rift
Changed planet to check for planet instead of not asteroid
Changed rejection limit from 1 to 5
Fixed planetResource to new API planetType
Changed max level from 7 to 9 // might need clean refactor
Updated rejection logic to correctly compute 5 max incoming transactions
Added 50 silvers check to prevent small sends that burn energy for nothing in case the script is called multiple times in a short period of time
Refactor MAX_LEVEL_PLANET
Bug fixes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I just need to update the screenshot and metadata.

@phated
Copy link
Contributor

phated commented May 29, 2021

Screenshot updated. Let's get this merged! Feel free to reach out if you need anything like extra keys/etc

@phated phated merged commit 4a1f37d into darkforest-eth:master May 29, 2021
phated added a commit that referenced this pull request May 29, 2021
* update distribute-silver

Added maxAsteroidLevel param
Added send all to space rift
Added withdraw all from space rift
Changed planet to check for planet instead of not asteroid
Changed rejection limit from 1 to 5
Fixed planetResource to new API planetType

* Update distribute-silver

Changed max level from 7 to 9 // might need clean refactor
Updated rejection logic to correctly compute 5 max incoming transactions
Added 50 silvers check to prevent small sends that burn energy for nothing in case the script is called multiple times in a short period of time

* Update plugin.js

Refactor MAX_LEVEL_PLANET
Bug fixes

* update screenshot

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants