update distribute-silver #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added maxAsteroidLevel param Added send all to space rift Added withdraw all from space rift Changed planet to check for planet instead of not asteroid Changed rejection limit from 1 to 5 Fixed planetResource to new API planetType
phated
reviewed
May 28, 2021
phated
reviewed
May 28, 2021
phated
reviewed
May 28, 2021
Changed max level from 7 to 9 // might need clean refactor Updated rejection logic to correctly compute 5 max incoming transactions Added 50 silvers check to prevent small sends that burn energy for nothing in case the script is called multiple times in a short period of time
Refactor MAX_LEVEL_PLANET Bug fixes
phated
approved these changes
May 29, 2021
|
Screenshot updated. Let's get this merged! Feel free to reach out if you need anything like extra keys/etc |
phated
added a commit
that referenced
this pull request
May 29, 2021
* update distribute-silver Added maxAsteroidLevel param Added send all to space rift Added withdraw all from space rift Changed planet to check for planet instead of not asteroid Changed rejection limit from 1 to 5 Fixed planetResource to new API planetType * Update distribute-silver Changed max level from 7 to 9 // might need clean refactor Updated rejection logic to correctly compute 5 max incoming transactions Added 50 silvers check to prevent small sends that burn energy for nothing in case the script is called multiple times in a short period of time * Update plugin.js Refactor MAX_LEVEL_PLANET Bug fixes * update screenshot Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added maxAsteroidLevel param
Added send all to space rift
Added withdraw all from space rift
Changed planet to check for planet instead of not asteroid
Changed rejection limit from 1 to 5
Fixed planetResource to new API planetType
With the new maxAsteroidLevel we can increase the rejection limit to send all silvers from small mines to one big planet without risking loosing silvers.