Repository navigation
Compare stdlib functions to OCaml - #2973
Merged
Merged
Conversation
The goal here is to avoid ignoring the differences, and instead enumerating them
DB::add_v0 in OCaml is sketchy to call but it should work in both platforms Needed to pass owner and canvas IDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though we had many implementation of the stdlib functions in F#, I hadn't tested them against the OCaml implementations to make sure there was no unchanged behaviour.
I added an API to run Dark code in the OCaml implementation and to compare the output to the Dark implementation. I hooked it up to the fuzzer and also to the existing unit tests. Then I went through all the existing functions and made sure the results were the same, occasionally fixing bugs in the F# implementation and adding notes about next steps once the F# implementation ships.
While I made as much bug-for-bug compatible as possible, I did aim to make error messages identical.
Fixes:
"Z̤͔ͧ̑̓ä͖̭̈̇lͮ̒ͫǧ̗͚̚o̙̔ͮ̇͐̇"tests)Other changes: