-
-
Notifications
You must be signed in to change notification settings - Fork 93
Optimization and benchmarking #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error caused all functions to be Impure, which caused us to trace the result of all functions, slowing down execution by 100x.
And similar, including removing duplicate versions
…uzz" This reverts commit a46ad60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some benchmarking and discovered that running fuzzbuzz in Dark was taking a ridiculously long time, like 800ms. It was only taking 70ms in OCaml (including the http and serialization overhead, which was probably most of it).
The problem was that pure functions were all being marked as impure, and so every function call was having its arguments and result saved.
This adds the benchmarking, the fix and also some other major changes:
taskv
->uply
value
->Ply.Ply
TaskOrValue<a'>
->Ply.Ply<'a>
taskv
from interpreter