Skip to content

Playwright #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 118 commits into from
Nov 2, 2021
Merged

Playwright #3228

merged 118 commits into from
Nov 2, 2021

Conversation

pbiggar
Copy link
Member

@pbiggar pbiggar commented Oct 29, 2021

This switches over from testcafe to playwright. Testcafe faked a lot of things, and we needed to often wait for testcafe to support something or had to hack around it. Playwright just uses the browser directly (also, it's much faster).

As opposed to before, integration tests now:

  • are much faster, running in half the time
  • check more errors
  • ensure that no console errors are printed
  • use their own package.json in
  • are reliable enough not to use retries too much
  • are in typescript
  • do not need the integration test hacks
  • are much more stable, due to better checking of completion conditions after actions
  • automatically upload the full trace in CI so you can see exactly what actually happened when the tests failed
  • wait until after the fsharp-backend tests so that they can load the generated blazor

TODO:

  • build and use updated dockerfile
    • remove circle.yml hack and set -x
  • update the README
  • move console logs into same directoy as other tests
  • remove testcafePrefix thing
  • latest playwright
  • add output-processing test to compile/CI
  • remove old integration tests
    • code
    • CI
    • rename playwright
    • package.json
  • set concurrency to 2 or 3
  • update prep.sh

Followups:

  • move test_appdata into integration-tests
  • make it work with F# server
  • make it work with blazor

@pbiggar pbiggar merged commit f845331 into main Nov 2, 2021
@pbiggar pbiggar deleted the paul/playwright branch November 2, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant