Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port HttpClient v0 - v4 to F# #3246

Merged
merged 79 commits into from
Feb 23, 2022
Merged

Port HttpClient v0 - v4 to F# #3246

merged 79 commits into from
Feb 23, 2022

Conversation

StachuDotNet
Copy link
Member

@StachuDotNet StachuDotNet commented Nov 21, 2021 •
edited
Loading

Relates to #3242. WIP.
The legacy HttpClient versions (v0 - v4) need to be ported to F# for the great F# migration.

@StachuDotNet
Copy link
Member Author

@pbiggar I'm seeing a number of HttpClient fns (both v5 and legacy) whose sqlSpecs are NotYetImplementedTODO. I would expect them to be NotQueryable. Should I go ahead and update to NotQueryable or am I mistaken?

@pbiggar
Copy link
Member

pbiggar commented Nov 22, 2021

@pbiggar I'm seeing a number of HttpClient fns (both v5 and legacy) whose sqlSpecs are NotYetImplementedTODO. I would expect them to be NotQueryable. Should I go ahead and update to NotQueryable or am I mistaken?

Yes, you can make them NotQueryable, thanks!

@pbiggar pbiggar linked an issue Nov 25, 2021 that may be closed by this pull request
HttpClient v0 - v4 #3256
Closed
@StachuDotNet StachuDotNet force-pushed the fsharp-port/legacy-http-clients branch from 898d29e to d8f04bc Compare January 28, 2022 23:10
@StachuDotNet
Copy link
Member Author

This branch has now been caught up with latest on main, and commit history is a bit cleaner.

At this point, there are some remaining TODOs:

  • there are a number of _-disabled tests in the various httpclienttestfiles/vX folder
  • tests involving fuzzers should be added, to find and resolve any other outstanding differences between the OCaml and F# implementations

@StachuDotNet StachuDotNet marked this pull request as ready for review January 28, 2022 23:14
@StachuDotNet
Copy link
Member Author

Additionally, it seems that CI won't run for my branch. Is that expected @pbiggar?

@pbiggar
Copy link
Member

pbiggar commented Jan 30, 2022

I don't remember what circle does with forks but I'll take a look. Obviously we should make it run

StachuDotNet and others added 20 commits February 22, 2022 20:49
@StachuDotNet @pbiggar
Remove duplicate legacy.ml.unported file
8b367bb
@StachuDotNet @pbiggar
Mark v5 LibHttpClient Dark fns as NotQueryable
8276516
@StachuDotNet @pbiggar
Correct code comment typo
3d8778f
@StachuDotNet @pbiggar
Improve FQFnName documentation
40a001a
@StachuDotNet @pbiggar
Add commentary to HttpClient tests; tidy
0c85706
@StachuDotNet @pbiggar
Update HttpClient tests; prepare to test legacy versions
0abbb6a
@StachuDotNet @pbiggar
Implement v4 of HttpClient lib fns
8e6e2bf
@StachuDotNet @pbiggar
Implement v3 of HttpClient lib fns
3fc9bd8
@StachuDotNet @pbiggar
Implement v2 of HttpClient lib fns
4de143b
@StachuDotNet @pbiggar
Implement v1 of HttpClient lib fns
477f250
@StachuDotNet @pbiggar
Implement v0 of HttpClient lib fns
dfa6c48
@StachuDotNet @pbiggar
Fix return type of some errored httpclient fns
5d1481e
@StachuDotNet @pbiggar
Fix error formatting of F# http calls
80159c1
@StachuDotNet @pbiggar
Trigger build
2f1dff4
@pbiggar
Rename LegacyHttpClient
49e53dc
@pbiggar
Move the base http client to its own file
5cb2320
@pbiggar
Split into multiple files
bbe259b
@pbiggar
Disable packages test for now
0992650
@pbiggar
Sync up the two http clients a bit
7623d14
@pbiggar
Tidyups for LegacyHttpClient2
1b15b89 
We no longer need the init function as this is done on the client now
@pbiggar
Make tests work in OCaml
5af3439
@pbiggar
Expand the RANDOM_STRING test to include every byte
3e26718
@pbiggar
Make HttpClients return bytes, and do utf8 outside of it
55f3848 
This matches the OCaml code (where a `string` is actually just bytes)
@pbiggar
Improve error strings
9a8a0f3
@pbiggar
Fix invalid string test
e0a99e4 
It turns out there's a bug in the ocaml version where the error escapes to the top. If we were maintaining the OCaml we'd fix this, so let's fix it here.
@pbiggar
Fix tests
527d18d
@pbiggar
Sync v1 and v2
1141659
@pbiggar
Fix v1 tests
c2cd527
@pbiggar
Fix accidentally testing wrong versions in wrong directories
7c120a1 
No wonder all the tests were passing
@pbiggar
Ensure all logs are printed before exiting
baeb2d6
@pbiggar
Remove unnecessary test code
6740856
@pbiggar
Remove extra field, fixing tests
1557575
@pbiggar
Fix test
3f0aa9a
@pbiggar
Fix tests
ee437af
@pbiggar
Fix v2 tests
1d79ea2
@pbiggar
Fix Httpclient v2 tests
002d60c
@pbiggar
Fix rest of v1 tests
984790c
@pbiggar
Copy v1 httpclient tests to v0
4c49199
@pbiggar
Delete old tests
c104669
@pbiggar
Sync v0 tests with v1
e795484
@pbiggar
Fix tests
fc3ca8a
@pbiggar
Fix float v0 tests
adc2d3b
@pbiggar
Finish fixing v0 request tests
9bc0b1a
@pbiggar
Finish v0 tests
df1b174
@pbiggar pbiggar force-pushed the fsharp-port/legacy-http-clients branch from f05126e to df1b174 Compare February 22, 2022 20:53
@pbiggar pbiggar merged commit db1b6df into darklang:main Feb 23, 2022
@StachuDotNet StachuDotNet deleted the fsharp-port/legacy-http-clients branch August 24, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpClient v0 - v4
2 participants
@StachuDotNet @pbiggar