-
-
Notifications
You must be signed in to change notification settings - Fork 109
Switch to System.Text.Json #3375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They would break if they were run twice in a row
The json parser was used to parse test results, and it glossed over a lot of tests where the output was a bit different.
a7963b5
to
4fc820a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several functions in Dark used JSON.Net, which supported some of the esoteric features of OCaml's Yojson, such as generating and parsing tokens like
NaN
andInfinity
.However, .NET is moving to using System.Text.Json, an idiomatic, extremely performant Json parser/serializer, that also plays nicer with Blazor.
JSON.Net has some differences with Yojson, and also introduces some surface area of its own. That means that moving to STJ via JSON.Net will probably introduce more problems that just going straight to STJ (even if STJ doesn't support some non-JSON-complaint things we were parsing/generating before).
This PR splits the JSON functions into internal (
DvalReprInternal
) and external (DvalReprExternal
) ones:The work was tracked in #3127
Major changes:
Modules:
Refactoring:
Json testing:
Misc Testing: