Blazor analysis result serialization now results in Rollbars#4043
Merged
StachuDotNet merged 2 commits intoMay 30, 2022
Merged
Conversation
Prior to this, serialization failures led to an inifinite loading spinner in the client.
Member
|
Why did it break before? I'm not seeing the difference. |
Member
Author
|
See here: dark/fsharp-backend/src/Wasm/Wasm.fs Lines 339 to 340 in b4f94ee Previously there was no try/with to wrap the call to Vanilla.serialize |
pbiggar
approved these changes
May 30, 2022
pbiggar
left a comment
pbiggar
left a comment
Member
There was a problem hiding this comment.
One question, feel free to merge once resolved.
StachuDotNet
commented
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, serialization failures led to an infinite loading spinner in the client.