64 bit serializers #4257
Merged
64 bit serializers #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StachuDotNet
approved these changes
Jul 11, 2022
It works on both (and IDs) so choose the canonical name.
pbiggar
force-pushed
the
paul/64-bit-serializers
branch
from
83b960e
to
aeacef8
Compare
|
Rebased, will merge after giving it a further look to ensure the rebase went well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes serializers on the frontend and backends to support 64bit values in ids (which are uint64 on the backend and strings on the frontend) and DInts (which have now been made 64 bit on the frontend, to match the backend).
64 bit numbers now work in analysis, as we can see below:
This is a precursor to making #4254 work properly, as I discovered the serialization issues there (see the discussion in that PR).