Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TFloat case in client's DType.decodeOld #4281

Merged
merged 1 commit into from Jul 14, 2022
Merged

Include TFloat case in client's DType.decodeOld #4281

merged 1 commit into from Jul 14, 2022

Conversation

StachuDotNet
Copy link
Member

@StachuDotNet
Copy link
Member Author

StachuDotNet commented Jul 14, 2022 •
edited

decodeOld is also missing a TAny - is that OK?

Note: I haven't tested this locally.

@pbiggar
Copy link
Member

pbiggar commented Jul 14, 2022

Probably needs it. Unsure.

@pbiggar pbiggar merged commit 26a9f25 into darklang:main Jul 14, 2022
@StachuDotNet StachuDotNet deleted the include-float-case-in-client-dtype-decodeold branch August 24, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbiggar pbiggar Awaiting requested review from pbiggar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StachuDotNet @pbiggar