Remove OCaml #4594
Merged
Remove OCaml #4594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StachuDotNet
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
As far as I can tell, these all seem like the appropriate removals. I assume dark-ocaml should stabilize (have darklang/dark-ocaml#7 merged) before this is merged?
Yes. Should be ready now - can you review? |
|
The dark-ocaml repo deploy worked great ( https://app.circleci.com/pipelines/github/darklang/dark-ocaml/13/workflows/467479a4-9fa1-4b75-a681-6761bb672247/jobs/83). So let's see how this one goes. |
|
This worked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Moved all the OCaml stuff into https://github.com/darklang/dark-ocaml. The remaining two containers can be built and deployed over there, if needs be, but hopefully they won't be touched until we remove them.
Multiple contributors have had issues with ocaml builds, including very high memory use (and hence extremely long build times, like 10 hours) and them not working on i5s. Best to just remove them, esp since we're probably a few months from removing them otherwise.