Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option.module_name isn't valid in Django 1.8 #405

Closed
reggieriser opened this issue Jul 23, 2015 · 2 comments
Closed

Option.module_name isn't valid in Django 1.8 #405

reggieriser opened this issue Jul 23, 2015 · 2 comments

Comments

@reggieriser
Copy link

In Django 1.8, Option.module_name as been renamed to model_name. You'll see a deprecation under 1.7, but some silent failures leading to missing parts of form names in rendered templates in Django 1.8. See usages in change_form.html (may be others too).

Here's the deprecation when running under Django 1.7.x:

[...]/lib/python2.7/site-packages/django/template/base.py:770: RemovedInDjango18Warning: Options.module_name has been deprecated in favor of model_name
current = getattr(current, bit)

@reggieriser
Copy link
Author

Thanks for the quick fixes, but it looks like there's still one lingering module_name usage on line 38 of change_form.html. Still getting a deprecation there.

@darklow
Copy link
Owner

darklow commented Jul 23, 2015

@reggieriser you're right, i don't know how i missed it, was searching multiple times :)
https://github.com/darklow/django-suit/blob/develop/suit/templates/admin/change_form.html#L38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants