11 changes: 1 addition & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -481,16 +481,7 @@ jobs:
- name: Install Base Dependencies
run: |
brew update > /dev/null || true
brew unlink python@3.8
sudo rm '/usr/local/bin/2to3'
# We need to remove following symlinks to avoid possible conflicts between python versions, resulting in CI run failing.
# This workaround introduced 22.12.2022 and can be removed when python 3.10 package install/upgrade will not be triggered by our bundle.
sudo rm '/usr/local/bin/idle3'
sudo rm '/usr/local/bin/pydoc3'
sudo rm '/usr/local/bin/python3'
sudo rm '/usr/local/bin/python3-config'
brew link --overwrite python@3.10 # workaround due to dependency on python 3.10
# brew upgrade --ignore-pinned # workaround introduced 18.07.2021, replace asap
brew upgrade || true
brew tap Homebrew/bundle
cd src/.ci
brew bundle --verbose
Expand Down
6 changes: 3 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ else(${perl_BIN} STREQUAL "perl_BIN-NOTFOUND")
message(STATUS "Found perl")
endif(${perl_BIN} STREQUAL "perl_BIN-NOTFOUND")

# we need intltool-merge for darktable.desktop
# we need intltool-merge for org.darktable.darktable.desktop
find_program(intltool_merge_BIN intltool-merge)
if(${intltool_merge_BIN} STREQUAL "intltool_merge_BIN-NOTFOUND")
message(STATUS "Missing intltool-merge")
Expand All @@ -294,10 +294,10 @@ else(${intltool_merge_BIN} STREQUAL "intltool_merge_BIN-NOTFOUND")
message(STATUS "Found intltool-merge")
endif(${intltool_merge_BIN} STREQUAL "intltool_merge_BIN-NOTFOUND")

# we need desktop-file-validate to check darktable.desktop
# we need desktop-file-validate to check org.darktable.darktable.desktop
find_program(desktop_file_validate_BIN desktop-file-validate)
if(${desktop_file_validate_BIN} STREQUAL "desktop_file_validate_BIN-NOTFOUND")
message(STATUS "Missing desktop-file-validate, problems in darktable.desktop might go unnoticed")
message(STATUS "Missing desktop-file-validate, problems in org.darktable.darktable.desktop might go unnoticed")
set(VALIDATE_DESKTOP_FILE 0)
else(${desktop_file_validate_BIN} STREQUAL "desktop_file_validate_BIN-NOTFOUND")
message(STATUS "Found desktop-file-validate")
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Requirements

* Linux (64-bit)
* FreeBSD (64-bit)
* Windows (64-bit), 8.1 w/ [UCRT](https://support.microsoft.com/en-us/topic/update-for-universal-c-runtime-in-windows-c0514201-7fe6-95a3-b0a5-287930f3560c), or later
* Windows (64-bit), 8.1 w/ [UCRT](https://support.microsoft.com/en-us/topic/update-for-universal-c-runtime-in-windows-c0514201-7fe6-95a3-b0a5-287930f3560c) and later
* macOS

*Big-endian platforms are not supported.*
Expand Down Expand Up @@ -316,7 +316,7 @@ This builds the software for your architecture only, with:
If you want to have dartkable displayed along your other applications, you only need to add a symbolic link:

```bash
ln -s /opt/darktable/share/applications/darktable.desktop /usr/share/applications/darktable.desktop
ln -s /opt/darktable/share/applications/org.darktable.darktable.desktop /usr/share/applications/org.darktable.darktable.desktop
```

Now, your custom-built darktable is ready to be used just like any pre-packaged software.
Expand Down Expand Up @@ -358,7 +358,7 @@ the test/unstable one will save in `~/.config/darktable-test`, and the two versi
Simply launch it from your desktop application menu or, from a terminal, run `darktable` or `/opt/darktable/bin/darktable`. If the installation did not create a launcher in your applications menu, run:

```bash
sudo ln -s /opt/darktable/share/applications/darktable.desktop /usr/share/applications/darktable.desktop
sudo ln -s /opt/darktable/share/applications/org.darktable.darktable.desktop /usr/share/applications/org.darktable.darktable.desktop
```

You may find darktable configuration files in `~/.config/darktable`.
Expand Down
2 changes: 0 additions & 2 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,6 @@ The following is a summary of the main features added to darktable

### Optional

- Bump libavif minimum required version from 0.8.2 to 0.9.1.

- New optional dependency: libjxl, minimum required version 0.7.0.


Expand Down
42 changes: 21 additions & 21 deletions data/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,53 +56,53 @@ if(NOT WIN32)
if("webp" IN_LIST DT_SUPPORTED_EXTENSIONS)
list(APPEND DESKTOP_MIME_TYPES image/webp)
endif()
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/darktable.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop.in)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/org.darktable.darktable.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop.in)
file(GLOB PO_FILES "${CMAKE_CURRENT_SOURCE_DIR}/../po/*.po")
add_custom_command(
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop
SOURCE ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop.in
COMMAND sh -c "${intltool_merge_BIN} --desktop-style ${CMAKE_CURRENT_SOURCE_DIR}/../po ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop"
MAIN_DEPENDENCY ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop.in
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop
SOURCE ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop.in
COMMAND sh -c "${intltool_merge_BIN} --desktop-style ${CMAKE_CURRENT_SOURCE_DIR}/../po ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop"
MAIN_DEPENDENCY ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop.in
DEPENDS ${PO_FILES}
)
add_custom_target(darktable.desktop_file ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop)
add_custom_target(darktable.desktop_file ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop)
if(${VALIDATE_DESKTOP_FILE})
add_custom_target(
validate_darktable_desktop ALL
COMMAND ${desktop_file_validate_BIN} --warn-kde ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop
DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop
COMMAND ${desktop_file_validate_BIN} --warn-kde ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop
DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/
COMMENT "Checking validity of darktable.desktop"
COMMENT "Checking validity of org.darktable.darktable.desktop"
)
add_dependencies(darktable.desktop_file validate_darktable_desktop)
endif()
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/darktable.desktop DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/applications COMPONENT DTApplication)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.darktable.darktable.desktop DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/applications COMPONENT DTApplication)
endif(NOT WIN32)

if(${VALIDATE_APPDATA_FILE})
add_custom_command(
OUTPUT ${DARKTABLE_SHAREDIR}/metainfo/darktable.appdata.xml
SOURCE ${CMAKE_CURRENT_SOURCE_DIR}/darktable.appdata.xml.in
OUTPUT ${DARKTABLE_SHAREDIR}/metainfo/org.darktable.darktable.appdata.xml
SOURCE ${CMAKE_CURRENT_SOURCE_DIR}/org.darktable.darktable.appdata.xml.in
COMMAND ${CMAKE_COMMAND} -E make_directory ${DARKTABLE_SHAREDIR}/metainfo
COMMAND sh -c "${intltool_merge_BIN} --xml-style ${CMAKE_CURRENT_SOURCE_DIR}/../po ${CMAKE_CURRENT_SOURCE_DIR}/darktable.appdata.xml.in ${DARKTABLE_SHAREDIR}/metainfo/darktable.appdata.xml"
COMMAND ${appstream_util_BIN} validate --nonet ${DARKTABLE_SHAREDIR}/metainfo/darktable.appdata.xml
MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/darktable.appdata.xml.in
COMMAND sh -c "${intltool_merge_BIN} --xml-style ${CMAKE_CURRENT_SOURCE_DIR}/../po ${CMAKE_CURRENT_SOURCE_DIR}/org.darktable.darktable.appdata.xml.in ${DARKTABLE_SHAREDIR}/metainfo/org.darktable.darktable.appdata.xml"
COMMAND ${appstream_util_BIN} validate --nonet ${DARKTABLE_SHAREDIR}/metainfo/org.darktable.darktable.appdata.xml
MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/org.darktable.darktable.appdata.xml.in
DEPENDS ${PO_FILES}
)
else()
add_custom_command(
OUTPUT ${DARKTABLE_SHAREDIR}/metainfo/darktable.appdata.xml
SOURCE ${CMAKE_CURRENT_SOURCE_DIR}/darktable.appdata.xml.in
OUTPUT ${DARKTABLE_SHAREDIR}/metainfo/org.darktable.darktable.appdata.xml
SOURCE ${CMAKE_CURRENT_SOURCE_DIR}/org.darktable.darktable.appdata.xml.in
COMMAND ${CMAKE_COMMAND} -E make_directory ${DARKTABLE_SHAREDIR}/metainfo
COMMAND sh -c "${intltool_merge_BIN} --xml-style ${CMAKE_CURRENT_SOURCE_DIR}/../po ${CMAKE_CURRENT_SOURCE_DIR}/darktable.appdata.xml.in ${DARKTABLE_SHAREDIR}/metainfo/darktable.appdata.xml"
MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/darktable.appdata.xml.in
COMMAND sh -c "${intltool_merge_BIN} --xml-style ${CMAKE_CURRENT_SOURCE_DIR}/../po ${CMAKE_CURRENT_SOURCE_DIR}/org.darktable.darktable.appdata.xml.in ${DARKTABLE_SHAREDIR}/metainfo/org.darktable.darktable.appdata.xml"
MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/org.darktable.darktable.appdata.xml.in
DEPENDS ${PO_FILES}
)
endif()

add_custom_target(darktable.appdata_file ALL DEPENDS ${DARKTABLE_SHAREDIR}/metainfo/darktable.appdata.xml)
add_custom_target(darktable.appdata_file ALL DEPENDS ${DARKTABLE_SHAREDIR}/metainfo/org.darktable.darktable.appdata.xml)

install(FILES ${DARKTABLE_SHAREDIR}/metainfo/darktable.appdata.xml DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/metainfo COMPONENT DTApplication)
install(FILES ${DARKTABLE_SHAREDIR}/metainfo/org.darktable.darktable.appdata.xml DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/metainfo COMPONENT DTApplication)

#
# Install watermarks
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<!-- Copyright (C) 2009-2021 darktable developers.
-->
<component type="desktop">
<id>darktable.desktop</id>
<id>org.darktable.darktable</id>
<name>darktable</name>
<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-3.0+</project_license>
Expand Down
File renamed without changes.
10 changes: 5 additions & 5 deletions data/themes/darktable.css
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,9 @@ Details :
.dt_overlays_mixed #thumb-main:hover .dt_thumb_btn,
.dt_overlays_mixed #thumb-main:selected .dt_thumb_btn,
.dt_overlays_mixed #thumb-main:hover #thumb-bottom-label,
.dt_overlays_hover_block #thumb-main:hover .dt_thumb_btn,
.dt_overlays_hover_block #thumb-main:hover .dt_thumb_btn:active,
.dt_overlays_hover_block #thumb-main:hover #thumb-bottom-label
.dt_overlays_hover_block #thumb-image:hover .dt_thumb_btn,
.dt_overlays_hover_block #thumb-image:hover .dt_thumb_btn:active,
.dt_overlays_hover_block #thumb-image:hover #thumb-bottom-label
{
color: @thumbnail_font_color;
}
Expand Down Expand Up @@ -2132,7 +2132,7 @@ Details :
.dt_overlays_always #thumb-main:hover #thumb-star:hover,
.dt_overlays_always_extended #thumb-main:hover #thumb-star:hover,
.dt_overlays_mixed #thumb-main:hover #thumb-star:hover,
.dt_overlays_hover_block #thumb-main:hover #thumb-star:hover
.dt_overlays_hover_block #thumb-image:hover #thumb-star:hover
{
color: @thumbnail_star_hover_color;
background-color: @thumbnail_star_bg_color;
Expand All @@ -2144,7 +2144,7 @@ Details :
.dt_overlays_always #thumb-main:hover #thumb-group-audio:hover,
.dt_overlays_always_extended #thumb-main:hover #thumb-group-audio:hover,
.dt_overlays_mixed #thumb-main:hover #thumb-group-audio:hover,
.dt_overlays_hover_block #thumb-main:hover #thumb-group-audio:hover
.dt_overlays_hover_block #thumb-image:hover #thumb-group-audio:hover
{
color: @thumbnail_fg_color;
}
Expand Down
Loading