Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[color calibration] now in current master defaults to "adaptation none (bypass) #15602 #16282

Closed
AxelG-DE opened this issue Feb 10, 2024 · 7 comments · Fixed by #16290
Closed
Labels
scope: image processing correcting pixels

Comments

@AxelG-DE
Copy link

Describe the bug

color calibration defaults in current master (4.7.0+510~gdb97084c9) to adaptation none (bypass)

@jenshannoschwalm per your wish now as separate issue :-)

Steps to reproduce

1.) discard history (e.g. in lighttable)
2.) go to color calibration
3.) see the "effect"

Expected behavior

color calibration should default to CAT16 as previously

Logfile | Screenshot | Screencast

grafik

Commit

PR #15602 by

Where did you obtain darktable from?

self compiled

darktable version

4.7.0+510~gdb97084c9

What OS are you using?

Linux

What is the version of your OS?

gentoo

Describe your system?

  • darktable version : 4.7.0-510-gdb97084c91
  • OS : Linux - kernel 6.7.4-gentoo
  • Distro : Gentoo Base System release 2.14
  • Processor : Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
  • Memory : 32 GB (4 x 8 GB) + 5GB Swap
  • Graphics card0 : NVIDIA GeForce GTX 1060 6GB
  • Graphics card1 : NVIDIA GeForce RTX 2070 SUPER
  • Graphics driver : nvidia-drivers-535.154.05
  • OpenCL installed : Yes (opencl-headers-2023.04.17)
  • OpenCL activated : Yes
  • Xorg : xorg-server-21.1.11
  • Desktop : KDE 5
  • GTK+ : gtk+-3.24.39
  • gcc : 13.2.1_p20240113-r1
  • cflags : CMAKE_FLAGS="-march=native-O2-mtune=native-pipe"
  • CMAKE_BUILD_TYPE : "Release"

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

pls see above

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

n/a

@ralfbrown ralfbrown added the scope: image processing correcting pixels label Feb 10, 2024
@jenshannoschwalm
Copy link
Collaborator

Don't see that here so far. Any special presets used? Your workflow settings?

@TurboGit
Copy link
Member

To reproduce you need to delete history from the Lighttable.

@AxelG-DE
Copy link
Author

To reproduce you need to delete history from the Lighttable.

Nervously I checked the initial issue 😨 but it is mentioned there 😀

@jenshannoschwalm
Copy link
Collaborator

Ok, on my side it works correct if one of the "scene referred" workflows is used, otherwise it's in "bypass" mode.

@AxelG-DE
Copy link
Author

grafik

@AxelG-DE
Copy link
Author

CC-adaptations_20240211-2024-02-11_13.37.37.mp4

@AxelG-DE
Copy link
Author

current implementation (11th Feb 14:40 UTC+1) of PR #16290 does help, but causes a new trouble (fixed temp to 5003k) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: image processing correcting pixels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants