Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Crop #17043

Closed
Sleepw1 opened this issue Jun 23, 2024 · 6 comments · Fixed by #17052
Closed

Error with Crop #17043

Sleepw1 opened this issue Jun 23, 2024 · 6 comments · Fixed by #17052

Comments

@Sleepw1
Copy link

Sleepw1 commented Jun 23, 2024

Describe the bug

There is something wrong with either the "rotate and perspective" or the "crop" module. If you rotate an image, for example 10 degrees, and later use crop to crop the image, the frame in the crop does not match the actual result.

Steps to reproduce

Use "Rotate an perspective" to rotate a picture, later crop the image with "crop" module.

Expected behavior

Crop to correct size.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.0

What OS are you using?

Linux

What is the version of your OS?

Linux mint 21,3

Describe your system?

No response

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@Sleepw1
Copy link
Author

Sleepw1 commented Jun 23, 2024

3
4
2
1

@AxelG-DE
Copy link

I have tested this on current master and I can confirm the issue.

One essential information is missing in above issue report:
This only happens if crop is set to the aspect ratio "original image"

@jenshannoschwalm could this be related to #16976 ?

@jenshannoschwalm
Copy link
Collaborator

Mmh, i can see your problem but can't reproduce here with images i have. Cou you share raw & xmp?

@Sleepw1
Copy link
Author

Sleepw1 commented Jun 23, 2024

Image and xmp file. peras.net/pp/PAS_1798.CR3, peras.net/pp/PAS_1798.CR3.xmp

@Sleepw1
Copy link
Author

Sleepw1 commented Jun 23, 2024

When the image is in portrait format: The error occurs on the right side of the image.
When the image is in landscape format: The error occurs at the bottom of the image

@AxelG-DE
Copy link

AxelG-DE commented Jun 27, 2024

@Sleepw1 your issue will be solved once PR #17052 is merged into master or 4.8.1

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants