Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misplaced "local copy" icon in lighttable zoom mode #2092

Closed
anarcat opened this Issue Feb 12, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@anarcat
Copy link
Contributor

anarcat commented Feb 12, 2019

Describe the bug

The "local copy" icon is misplaced when in "zoom" mode in the light table. It should be in the upper right of the picture (I guess?), at least if it follows the main light table layout. Instead, it clobbers the "G" button.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the lighttable view
  2. Click on an image, then copy locally in the Selected images section
  3. Hit the z key to zoome the image in
  4. Try to find the "copied locally" marker

Expected behavior

Here is how the image look when zoomed out in the light table:

image

Screenshots

Here it what the upper left of the zoomed picture looks like:

image

Platform (please complete the following information):

  • OS: Debian GNU/Linux 10 "buster"
  • Version 2.6.0-1

Additional context

I might have modified the keybinding for "zoom". I don't exactly remember, but I suspect I might have switched between z (lowercase) and Z (uppercase) to make the "z" key "permanent" (that it "sticks" when you release it). Or maybe that's the default? I'm sorry I forgot that part... :/

@TurboGit TurboGit closed this in 8f7e462 Feb 12, 2019

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Feb 12, 2019

Good catch! Thanks. Should be fixed now.

@anarcat

This comment has been minimized.

Copy link
Contributor Author

anarcat commented Feb 12, 2019

awesome, thanks for the speedy resolution! :)

TurboGit added a commit that referenced this issue Feb 12, 2019

view: fix location of local copy flag.
Also make the flag a bit bigger.

Fixes #2092.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.