Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone curve creates countless new entries/lines in history stack #2420

Closed
AxelG-DE opened this issue Apr 17, 2019 · 8 comments

Comments

Projects
None yet
3 participants
@AxelG-DE
Copy link

commented Apr 17, 2019

Describe the bug
when ever you click or track anything in the controls of tone curve, it creates a new entry in the histroy stack. Rapidly you reach 300 lines and lose all performance of dt.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'darktroom'
  2. Click on 'tone curve'
  3. drag the black point to somewhere or activate a mask and change chormacity'
  4. enjoy the error

Expected behavior
like all the other modules and the behavior before, there should be merely one line in history stack per each attempt to change or edit

Screenshots
Screenshot_20190417_230102

Platform (please complete the following information):

  • OS: [ gentoo linux]
  • Version [darktable 2.7.0+1025~g0384a4bb1-dirty]

Additional context
Add any other context about the problem here.

@AxelG-DE

This comment has been minimized.

Copy link
Author

commented Apr 19, 2019

maybe it is not just, or not at all a tone curve issue, just now I figured strange things in the history stack... (unfortunately cannot reproduce that color zones created hell of line too)

@TurboGit

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

I also get this from time to time (rare though) and generally compressing the history fix the issue.

@AxelG-DE

This comment has been minimized.

Copy link
Author

commented Apr 21, 2019

Yes compressing history stack does help unless you touch tone curve again :-)

Actually 2.7-1040 does not show this behavior anymore. Probably this issue can be closed?

@TurboGit

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Ok, closing.

@AxelG-DE

This comment has been minimized.

Copy link
Author

commented May 9, 2019

@TurboGit
acc. to #2538 does it make sense, to reopen this one?

@AxelG-DE

This comment has been minimized.

Copy link
Author

commented May 31, 2019

@TurboGit
Please see this video https://youtu.be/WH_XMlEv398
at around 9 minutes and please reopen this bug report.

@brucewilliamsphotography is using official release, and I still see this on git-master from time to time.

Also I have big suspiciousy, once we solved this, we might also solve other performance issues like #2514

Thanks in advance!

@dtorop

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

I've also seen this over the years, but not recently. Hard to remember, but my suspicion may have been that it happened with older XMPs being opened with newer versions of darktable, but I never verified this. Perhaps the workaround was to switch to lighttable then back to darkroom.

@AxelG-DE

This comment has been minimized.

Copy link
Author

commented Jun 3, 2019

@dtorop
That pic from Bruce was a very new one, so was my case.

In that #2514 case I have a similar issue, that every time I change levels, I get a new entry in history stack. Indeed workarounds are possible but it feels buggy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.