Skip to content

[Denoise profiled] strength increments by 0.5 instead of 0.05 if scrolled by mouse wheel #5693

Closed
@AxelG-DE

Description

Describe the bug

Using mouse wheel, the strength of denoise profiled increments by 0.5 (and 0.05 when keeping ctrl pressed)

To Reproduce

  1. Go to darkroom / denoise profiled
  2. click on strength
  3. Scroll with mouse wheel
  4. See error

Expected behavior

as in the past, increment by 0.05 (and with ctrl pressed by 0.005)

bisect

1c31560 is the first bad commit
commit 1c31560
Author: Diederik ter Rahe dterrahe@yahoo.com
Date: Sat May 30 10:48:20 2020 +0100

[denoiseprofile.c] introspection, refactoring, janitorial

src/iop/denoiseprofile.c | 563 ++++++++++++++++++-----------------------------
1 file changed, 212 insertions(+), 351 deletions(-)

@dterrahe may I kindly ask you to look into it?

Platform (please complete the following information):

  • darktable version : 3.1.0+2414~g50eaaaa70
  • OS : Linux - kernel 5.7.6-gentoo
  • Distro : Gentoo Base System release 2.6
  • Processor : Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
  • Memory : 32 GB (4 x 8 GB) + 5GB Swap
  • Graphics card0 : GeForce GTX 1060 6GB
  • Graphics card1 : GeForce RTX 2070 SUPER
  • Graphics driver : nvidia-drivers-440.100-r1
  • OpenCL installed : Yes (opencl-headers-2020.03.13-r1)
  • OpenCL activated : Yes
  • Xorg : xorg-server-1.20.8
  • Desktop : KDE 5
  • GTK+ : gtk+-3.24.16
  • gcc : x86_64-pc-linux-gnu-9.3.0
  • cflags : CFLAGS="-march=native-O2-mtune=native-pipe"
  • CMAKE_BUILD_TYPE : "Release"

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions