Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: auto-set rotate angle based on exif RollAngle #6423

Open
trougnouf opened this issue Oct 1, 2020 · 6 comments
Open

FR: auto-set rotate angle based on exif RollAngle #6423

trougnouf opened this issue Oct 1, 2020 · 6 comments
Labels
bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver feature: enhancement current features to improve no-issue-activity scope: image processing correcting pixels scope: software support wiring external libs and software: LittleCMS, colord, G'MIC, enfuse/enblend, etc.

Comments

@trougnouf
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'm getting a camera which does not display the rotation meter along with the histogram (Nikon Z6). Rotation wouldn't be an issue if it were automatically corrected based on the EXIF data. Many cameras offer a RollAngle exif tag that can be used for this purpose.

Describe the solution you'd like

The crop and rotate module could be automatically activated with the angle based on exif data. This could be set as an optional auto-apply setting like sharpen or base-curve.

Additional context

I cannot find the RollAngle tag in a sample Nikon Z6 shot nor in my Fujifilm X-T1 but I believe they would be part of the many undocumented tags, so I will first focus on getting those parsed in exiftool.

The Nikon D850 is a camera which does have the RollAngle tag correctly parsed in exifinfo. Sample images which could be used to develop this FR can be found on https://raw.pixls.us/#repo or https://www.photographyblog.com/previews/nikon_d850_photos

@johnny-bit
Copy link
Member

For us to be able to use it, those tags would need to be exposed not by exiftool but by exiv2 library, so first step would need to be to ask in exiv2 👍 once that is done, we can think about having it, however crash and rot is finnicky module to work with

@ptilopteri
Copy link

This would be a great enhancement.
note: the Nikon D500 also includes "roll angle" in exif data

@trougnouf
Copy link
Contributor Author

Thank you ! I've opened a FR on Exiv2/exiv2#1334

@jenshannoschwalm
Copy link
Collaborator

May be a Lua script would be better because exif2 is not implementing camera specific tags quick.

Also it would require changes in dt internals to correct automatically.

@github-actions
Copy link

github-actions bot commented Nov 1, 2020

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@johnny-bit johnny-bit added bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver feature: enhancement current features to improve scope: image processing correcting pixels scope: software support wiring external libs and software: LittleCMS, colord, G'MIC, enfuse/enblend, etc. labels Jun 13, 2021
@github-actions
Copy link

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver feature: enhancement current features to improve no-issue-activity scope: image processing correcting pixels scope: software support wiring external libs and software: LittleCMS, colord, G'MIC, enfuse/enblend, etc.
Projects
None yet
Development

No branches or pull requests

4 participants